-
Robert Knight authored
Change the sidebar toggle button from being a toggle button with the label "Show annotation sidebar" to a normal button that changes between "Show annotation sidebar" and "Hide annotation sidebar" labels. WAI-ARIA guidelines [1] suggest that both are valid ways of implementing toggle actions and looking around web and native apps on macOS one can find plenty of both for similar actions. The one clear requirement is to use a label change OR aria-pressed, but not both. We think [2] a label change will make the state slightly easier to quickly discern and it provides a more useful tooltip for sighted desktop users. [1] https://www.w3.org/TR/wai-aria-practices-1.1/#button [2] https://github.com/hypothesis/client/issues/2055#issuecomment-622512247 Fixes https://github.com/hypothesis/client/issues/2055.
5471223e