• Robert Knight's avatar
    Remove usage of bindings in component constructors · f2fcb297
    Robert Knight authored
    In Angular 1.6 the behavior where inputs to components ("bindings")
    were accessible in the controller's constructor was deprecated [1] but a
    switch was made available to re-enable the old behavior to assist migration.
    This switch has been removed in Angular 1.7, so we need to stop relying
    on it before we can upgrade.
    
    The correct thing to do is to put all init logic which accesses bindings
    (`this.someBindingName`) in the `$onInit` lifecycle method.
    
    This commit makes the minimal amount of changes to enable the app and
    tests to run without requiring pre-assigned bindings.
    
    [1] https://toddmotto.com/angular-1-6-is-here
    f2fcb297
annotation-viewer-content-test.js 4.28 KB