Remove unused selector

Remove unused selector and tidy up reference ordering

src/sidebar/store/modules/filters.js

@@ -127,16 +127,6 @@ const actions = actionTypes(update);
 
 // Action creators
 
-/** Set the query used to filter displayed annotations. */
-function setFilterQuery(query) {
-  return dispatch => {
-    dispatch({
-      type: actions.SET_FILTER_QUERY,
-      query: query,
-    });
-  };
-}
-
 /**
  * Clears any applied filters, changes the focused user and sets
  * focused enabled to `true`.
@@ -147,6 +137,14 @@ function changeFocusModeUser(user) {
   return { type: actions.CHANGE_FOCUS_MODE_USER, user };
 }
 
+/** Set the query used to filter displayed annotations. */
+function setFilterQuery(query) {
+  return {
+    type: actions.SET_FILTER_QUERY,
+    query: query,
+  };
+}
+
 /**
  * Toggle whether or not a (user-)focus mode is applied, either inverting the
  * current active state or setting it to a target `active` state, if provided.

src/sidebar/store/modules/selection.js

@@ -87,10 +87,6 @@ const setTab = (newTab, oldTab) => {
   };
 };
 
-/**
- * Return state object representing a reset selection. This
- * resets user-set filters (but leaves focus mode intact)
- */
 const resetSelection = () => {
   return {
     forcedVisible: {},
@@ -311,20 +307,6 @@ const forcedVisibleAnnotations = createSelector(
   forcedVisible => trueKeys(forcedVisible)
 );
 
-/**
- * Returns the annotation ID of the first annotation in the selection that is
- * selected (`true`) or `null` if there are none.
- *
- * @type {(state: any) => string|null}
- */
-const getFirstSelectedAnnotationId = createSelector(
-  state => state.selected,
-  selection => {
-    const selectedIds = trueKeys(selection);
-    return selectedIds.length ? selectedIds[0] : null;
-  }
-);
-
 /**
  * Are any annotations currently selected?
  *
@@ -352,6 +334,9 @@ function selectedTab(state) {
   return state.selectedTab;
 }
 
+/**
+ * @return {SelectionState}
+ */
 function selectionState(state) {
   const selectionState = {
     expanded: expandedMap(state),
@@ -401,7 +386,6 @@ function sortKeys(state) {
  * // Selectors
  * @prop {() => Object<string,boolean>} expandedMap
  * @prop {() => string[]} forcedVisibleAnnotations
- * @prop {() => string|null} getFirstSelectedAnnotationId
  * @prop {() => boolean} hasSelectedAnnotations
  * @prop {() => string[]} selectedAnnotations
  * @prop {() => string} selectedTab
@@ -429,7 +413,6 @@ export default {
   selectors: {
     expandedMap,
     forcedVisibleAnnotations,
-    getFirstSelectedAnnotationId,
     hasSelectedAnnotations,
     selectedAnnotations,
     selectedTab,

src/sidebar/store/modules/test/selection-test.js

@@ -18,18 +18,6 @@ describe('sidebar/store/modules/selection', () => {
     store = createStore([annotations, filters, selection, route], fakeSettings);
   });
 
-  describe('getFirstSelectedAnnotationId', function () {
-    it('returns the first selected annotation id it finds', function () {
-      store.selectAnnotations([1, 2]);
-      assert.equal(store.getFirstSelectedAnnotationId(), 1);
-    });
-
-    it('returns null if no selected annotation ids are found', function () {
-      store.selectAnnotations([]);
-      assert.isNull(store.getFirstSelectedAnnotationId());
-    });
-  });
-
   describe('setForcedVisible', function () {
     it('sets the visibility of the annotation', function () {
       store.setForcedVisible('id1', true);