Rename AnnotationShareInfo => AnnotationGroupInfo

Remove the annotation privacy information from this component, since that status
is already provided by the lock icon next to the username, and update the
component to reflect its current purpose.

src/sidebar/components/Annotation/AnnotationShareInfo.tsx → src/sidebar/components/Annotation/AnnotationGroupInfo.tsx

@@ -3,19 +3,17 @@ import classnames from 'classnames';
 
 import type { Group } from '../../../types/api';
 
-export type AnnotationShareInfoProps = {
+export type AnnotationGroupInfoProps = {
   /** Group to which the annotation belongs */
   group: Group;
-  isPrivate: boolean;
 };
 
 /**
- * Render information about what group an annotation is in and
- * whether it is private to the current user (only me)
+ * Render information about what group an annotation is in.
  *
- * @param {AnnotationShareInfoProps} props
+ * @param {AnnotationGroupInfoProps} props
  */
-function AnnotationShareInfo({ group, isPrivate }: AnnotationShareInfoProps) {
+function AnnotationGroupInfo({ group }: AnnotationGroupInfoProps) {
   // Only show the name of the group and link to it if there is a
   // URL (link) returned by the API for this group. Some groups do not have links
   const linkToGroup = group?.links.html;
@@ -44,13 +42,8 @@ function AnnotationShareInfo({ group, isPrivate }: AnnotationShareInfoProps) {
           </div>
         </Link>
       )}
-      {isPrivate && !linkToGroup && (
-        <div className="text-color-text-light" data-testid="private-info">
-          Only me
-        </div>
-      )}
     </>
   );
 }
 
-export default AnnotationShareInfo;
+export default AnnotationGroupInfo;

src/sidebar/components/Annotation/AnnotationHeader.tsx

@@ -22,7 +22,7 @@ import { isPrivate } from '../../helpers/permissions';
 import { withServices } from '../../service-context';
 import { useSidebarStore } from '../../store';
 import AnnotationDocumentInfo from './AnnotationDocumentInfo';
-import AnnotationShareInfo from './AnnotationShareInfo';
+import AnnotationGroupInfo from './AnnotationGroupInfo';
 import AnnotationTimestamps from './AnnotationTimestamps';
 import AnnotationUser from './AnnotationUser';
 
@@ -149,12 +149,7 @@ function AnnotationHeader({
           className="flex gap-x-1 items-baseline flex-wrap-reverse"
           data-testid="extended-header-info"
         >
-          {group && (
-            <AnnotationShareInfo
-              group={group}
-              isPrivate={isPrivate(annotation.permissions)}
-            />
-          )}
+          {group && <AnnotationGroupInfo group={group} />}
           {!isEditing && isHighlight(annotation) && (
             <HighlightIcon
               title="This is a highlight. Click 'edit' to add a note or tag."

src/sidebar/components/Annotation/test/AnnotationShareInfo-test.js → src/sidebar/components/Annotation/test/AnnotationGroupInfo-test.js

@@ -4,13 +4,13 @@ import {
 } from '@hypothesis/frontend-testing';
 import { mount } from 'enzyme';
 
-import AnnotationShareInfo, { $imports } from '../AnnotationShareInfo';
+import AnnotationGroupInfo, { $imports } from '../AnnotationGroupInfo';
 
-describe('AnnotationShareInfo', () => {
+describe('AnnotationGroupInfo', () => {
   let fakeGroup;
 
-  const createAnnotationShareInfo = props => {
-    return mount(<AnnotationShareInfo group={fakeGroup} {...props} />);
+  const createAnnotationGroupInfo = props => {
+    return mount(<AnnotationGroupInfo group={fakeGroup} {...props} />);
   };
 
   beforeEach(() => {
@@ -31,7 +31,7 @@ describe('AnnotationShareInfo', () => {
 
   describe('group link', () => {
     it('should show a link to the group for extant, first-party groups', () => {
-      const wrapper = createAnnotationShareInfo();
+      const wrapper = createAnnotationGroupInfo();
 
       const groupLink = wrapper.find('a');
 
@@ -40,57 +40,33 @@ describe('AnnotationShareInfo', () => {
     });
 
     it('should display a group icon for private and restricted groups', () => {
-      const wrapper = createAnnotationShareInfo();
+      const wrapper = createAnnotationGroupInfo();
 
       assert.isTrue(wrapper.find('GroupsIcon').exists());
     });
 
     it('should display a public/world icon for open groups', () => {
       fakeGroup.type = 'open';
-      const wrapper = createAnnotationShareInfo();
+      const wrapper = createAnnotationGroupInfo();
 
       assert.isTrue(wrapper.find('GlobeIcon').exists());
     });
 
     it('should not show a link to third-party groups', () => {
       // Third-party groups have no `html` link
-      const wrapper = createAnnotationShareInfo({
+      const wrapper = createAnnotationGroupInfo({
         group: { name: 'A Group', links: {} },
       });
-      const groupLink = wrapper.find('.AnnotationShareInfo__group');
+      const groupLink = wrapper.find('.AnnotationGroupInfo__group');
 
       assert.notOk(groupLink.exists());
     });
   });
 
-  describe('"only you" information', () => {
-    it('should not show privacy information if annotation is not private', () => {
-      const wrapper = createAnnotationShareInfo();
-
-      const privacy = wrapper.find('.AnnotationShareInfo__private');
-
-      assert.notOk(privacy.exists());
-    });
-
-    context('private annotation', () => {
-      it('should show "only me" text for annotation in third-party group', () => {
-        const wrapper = createAnnotationShareInfo({
-          group: { name: 'Some Name', links: {} },
-          isPrivate: true,
-        });
-
-        const privacyText = wrapper.find('[data-testid="private-info"]');
-
-        assert.isOk(privacyText.exists());
-        assert.equal(privacyText.text(), 'Only me');
-      });
-    });
-  });
-
   it(
     'should pass a11y checks',
     checkAccessibility({
-      content: () => createAnnotationShareInfo(),
+      content: () => createAnnotationGroupInfo(),
     }),
   );
 });

src/sidebar/components/Annotation/test/AnnotationHeader-test.js

@@ -339,7 +339,7 @@ describe('AnnotationHeader', () => {
           fakeStore.route.returns(route);
           const wrapper = createAnnotationHeader();
           assert.equal(
-            wrapper.find('AnnotationShareInfo').exists(),
+            wrapper.find('AnnotationGroupInfo').exists(),
             groupVisible,
           );
         });
@@ -350,7 +350,7 @@ describe('AnnotationHeader', () => {
         fakeStore.getGroup.returns(undefined);
         const wrapper = createAnnotationHeader();
 
-        assert.isFalse(wrapper.find('AnnotationShareInfo').exists());
+        assert.isFalse(wrapper.find('AnnotationGroupInfo').exists());
       });
     });