Commit 0f8768c4 authored by Kyle Keating's avatar Kyle Keating

Fix a11y lint issues in menu.js

- Disable lint rules: "no-static-element-interactions"  and "click-events-have-key-events"  on the menu wrapper. It is acceptable to allow click event handling on static elements when its used to catch event propagation

- Add a -1 tabindex on menu__content for lint purposes
parent 96a51489
...@@ -105,7 +105,7 @@ export default function Menu({ ...@@ -105,7 +105,7 @@ export default function Menu({
}; };
return ( return (
// FIXME-A11Y // See https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md#case-the-event-handler-is-only-being-used-to-capture-bubbled-events
// eslint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events // eslint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events
<div <div
className="menu" className="menu"
...@@ -145,8 +145,6 @@ export default function Menu({ ...@@ -145,8 +145,6 @@ export default function Menu({
{isOpen && ( {isOpen && (
<Fragment> <Fragment>
{menuArrow(arrowClass)} {menuArrow(arrowClass)}
{/* FIXME-A11Y */}
{/* eslint-disable-next-line jsx-a11y/interactive-supports-focus */}
<div <div
className={classnames( className={classnames(
'menu__content', 'menu__content',
...@@ -154,6 +152,7 @@ export default function Menu({ ...@@ -154,6 +152,7 @@ export default function Menu({
contentClass contentClass
)} )}
role="menu" role="menu"
tabIndex="-1"
onClick={closeMenu} onClick={closeMenu}
onKeyPress={handleMenuKeyPress} onKeyPress={handleMenuKeyPress}
> >
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment