Skip to content

C
coopwire-hypothesis
Commit 1dbbd4a9 authored by Robert Knight's avatar Robert Knight
Browse files
Options

Make client test page load embed from same hostname as test page 

Previously the live reload server at http://localhost:3000 hardcoded the
embed script to 'http://localhost:5000' which would cause the embed to
fail to load if accessing the live reload server via a different IP.

This happens when accessing the server through a VirtualBox Guest when
using the default networking settings or when accessing it from a say, a
mobile device on the same WiFi network as a laptop serving the dev
environment.

Instead use the same hostname for the live reload WebSocket server
and embed script as the client test page is served from.
parent 5534de80
Show whitespace changes
Inline Side-by-side
Showing with 7 additions and 2 deletions
scripts/gulp/live-reload-server.js
View file @ 1dbbd4a9
......@@ -38,9 +38,11 @@ function LiveReloadServer(port, appServer) {
<body>
<pre style="margin: 75px;">${changelogText()}</pre>
<script>
var appHost = document.location.hostname;
window.hypothesisConfig = function () {
return {
liveReloadServer: 'ws://localhost:${port}',
liveReloadServer: 'ws://' + appHost + ':${port}',
// Open the sidebar when the page loads
firstRun: true,
......@@ -52,8 +54,11 @@ function LiveReloadServer(port, appServer) {
window.location.reload();
}
});
var embedScript = document.createElement('script');
embedScript.src = '${appServer}/embed.js'.replace('localhost', appHost);
document.body.appendChild(embedScript);
</script>
<script src="${appServer}/embed.js"></script>
</body>
</html>
`;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment