Commit 2fc675f6 authored by Juan Corona's avatar Juan Corona Committed by Juan Corona

Sustain the config object’s immutability

I want to prevent the potential chaining of config params here since I plan to pass the config object around in new places, the sub-frame guest level for example.
parent eb093f7e
......@@ -28,9 +28,9 @@ module.exports = class Host extends Guest
JSON.stringify(Object.assign({}, config, {sidebarAppUrl: undefined, pluginClasses: undefined }))
)
if config.sidebarAppUrl and '?' in config.sidebarAppUrl
config.sidebarAppUrl += '&' + configParam
sidebarAppSrc = config.sidebarAppUrl + '&' + configParam
else
config.sidebarAppUrl += '?' + configParam
sidebarAppSrc = config.sidebarAppUrl + '?' + configParam
# Create the iframe
app = $('<iframe></iframe>')
......@@ -38,7 +38,7 @@ module.exports = class Host extends Guest
# enable media in annotations to be shown fullscreen
.attr('allowfullscreen', '')
.attr('seamless', '')
.attr('src', config.sidebarAppUrl)
.attr('src', sidebarAppSrc)
.addClass('h-sidebar-iframe')
@frame = $('<div></div>')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment