Fix autoDismiss option ignored in toast messages

src/sidebar/services/test/toast-messenger-test.js

@@ -91,25 +91,25 @@ describe('ToastMessengerService', () => {
       assert.notCalled(fakeStore.addToastMessage);
     });
 
-    it('adds a new error toast message to the store', () => {
-      fakeStore.hasToastMessage.returns(false);
-
-      service.error('boo');
-
-      assert.calledWith(
-        fakeStore.addToastMessage,
-        sinon.match({ type: 'error', message: 'boo' }),
-      );
-    });
-
-    it('does not dismiss the message if `autoDismiss` is false', () => {
-      fakeStore.hasToastMessage.returns(false);
-      fakeStore.getToastMessage.returns(undefined);
-
-      service.error('boo', { autoDismiss: false });
-
-      assert.notCalled(fakeStore.getToastMessage);
-      assert.notCalled(fakeStore.removeToastMessage);
+    [
+      { autoDismiss: undefined, expectedAutoDismiss: true },
+      { autoDismiss: true, expectedAutoDismiss: true },
+      { autoDismiss: false, expectedAutoDismiss: false },
+    ].forEach(({ autoDismiss, expectedAutoDismiss }) => {
+      it('adds a new error toast message to the store', () => {
+        fakeStore.hasToastMessage.returns(false);
+
+        service.error('boo', { autoDismiss });
+
+        assert.calledWith(
+          fakeStore.addToastMessage,
+          sinon.match({
+            type: 'error',
+            message: 'boo',
+            autoDismiss: expectedAutoDismiss,
+          }),
+        );
+      });
     });
   });
 

src/sidebar/services/toast-messenger.ts

@@ -114,6 +114,7 @@ export class ToastMessengerService extends TinyEmitter {
       id,
       message: messageText,
       visuallyHidden,
+      autoDismiss,
     };
 
     this._store.addToastMessage(message);