Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
3ddf3cff
Commit
3ddf3cff
authored
Jan 27, 2022
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Explain why new guests must be added to `_guestRPC` map immediately
parent
71476ef9
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
2 deletions
+5
-2
frame-sync.js
src/sidebar/services/frame-sync.js
+5
-2
No files found.
src/sidebar/services/frame-sync.js
View file @
3ddf3cff
...
...
@@ -225,12 +225,15 @@ export class FrameSyncService {
/** @type {PortRPC<GuestToSidebarEvent, SidebarToGuestEvent>} */
const
guestRPC
=
new
PortRPC
();
// Generate a temporary ID for this guest until we learn its "real" ID.
// Add guest RPC to map with a temporary ID until we learn the real ID.
//
// We need to add the guest to the map immediately so that any notifications
// sent from this service to all guests, before we learn the real frame ID,
// are sent to this new guest.
++
this
.
_nextGuestId
;
let
frameIdentifier
=
/** @type {string|null} */
(
`temp-
${
this
.
_nextGuestId
}
`
);
this
.
_guestRPC
.
set
(
frameIdentifier
,
guestRPC
);
// Update document metadata for this guest. We currently assume that the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment