Commit 44d4f3ad authored by Robert Knight's avatar Robert Knight

Actually build the app after running `yarn version`

In Yarn v3, the "version" script defined in `package.json` is no longer run any
more.
parent fb37609b
...@@ -48,7 +48,9 @@ jobs: ...@@ -48,7 +48,9 @@ jobs:
QA_VERSION=$(git tag --list | sort --version-sort --reverse | head -n1 | tail -c +2)-$LAST_COMMIT_HASH QA_VERSION=$(git tag --list | sort --version-sort --reverse | head -n1 | tail -c +2)-$LAST_COMMIT_HASH
echo "QA_VERSION=$QA_VERSION" >> $GITHUB_ENV echo "QA_VERSION=$QA_VERSION" >> $GITHUB_ENV
- name: Build app - name: Build app
run: yarn version "$QA_VERSION" run: |
yarn version "$QA_VERSION"
make clean build
- name: Upload files to Sentry - name: Upload files to Sentry
env: env:
SENTRY_AUTH_TOKEN: ${{ secrets.sentry_auth_token }} SENTRY_AUTH_TOKEN: ${{ secrets.sentry_auth_token }}
...@@ -95,7 +97,9 @@ jobs: ...@@ -95,7 +97,9 @@ jobs:
git push https://github.com/hypothesis/client.git v$NEW_VERSION git push https://github.com/hypothesis/client.git v$NEW_VERSION
sleep 2 # Wait for GitHub to see new tag sleep 2 # Wait for GitHub to see new tag
- name: Build app - name: Build app
run: yarn version $NEW_VERSION run: |
yarn version $NEW_VERSION
make clean build
- name: Upload files to Sentry - name: Upload files to Sentry
env: env:
SENTRY_AUTH_TOKEN: ${{ secrets.sentry_auth_token }} SENTRY_AUTH_TOKEN: ${{ secrets.sentry_auth_token }}
......
...@@ -117,8 +117,7 @@ ...@@ -117,8 +117,7 @@
"format": "prettier --cache --list-different --write '**/*.{js,scss,ts,tsx,d.ts}'", "format": "prettier --cache --list-different --write '**/*.{js,scss,ts,tsx,d.ts}'",
"test": "gulp test", "test": "gulp test",
"test:watch": "gulp test --live", "test:watch": "gulp test --live",
"typecheck": "tsc --build tsconfig.json", "typecheck": "tsc --build tsconfig.json"
"version": "make clean build"
}, },
"packageManager": "yarn@3.6.0" "packageManager": "yarn@3.6.0"
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment