Commit 484688a7 authored by Randall Leeds's avatar Randall Leeds

Clean up some try/catch with Promises

parent fdb38397
...@@ -176,17 +176,14 @@ module.exports = class Guest extends Annotator ...@@ -176,17 +176,14 @@ module.exports = class Guest extends Annotator
# Try to anchor all the targets # Try to anchor all the targets
anchorTargets = (targets = []) => anchorTargets = (targets = []) =>
anchorPromises = for target in targets when target.selector for target in targets when target.selector
try Promise.resolve()
this.anchorTarget(target) .then(=> this.anchorTarget(target))
.then(highlightRange) .then(highlightRange)
.then(succeed(target), fail(target)) .then(succeed(target), fail(target))
catch error
Promise.reject(error).catch(fail(target))
return Promise.all(anchorPromises).then(finish)
# Start anchoring in the background # Start anchoring in the background
anchorTargets(annotation.target) Promise.all(anchorTargets(annotation.target)).then(finish)
annotation annotation
...@@ -337,13 +334,11 @@ module.exports = class Guest extends Annotator ...@@ -337,13 +334,11 @@ module.exports = class Guest extends Annotator
notNull = (selectors) -> notNull = (selectors) ->
(s for s in selectors when s?) (s for s in selectors when s?)
selectors = ANCHOR_TYPES.map (type) => selectors = for type in ANCHOR_TYPES
try promise = Promise.resolve(type).then (t) ->
Promise.resolve(type.fromRange(range, options)).then (a) -> Promise.resolve(t.fromRange(range, options)).then (a) ->
Promise.resolve(a.toSelector(options)) Promise.resolve(a.toSelector(options))
, -> null promise.catch(-> null)
catch
Promise.resolve()
return Promise.all(selectors).then(notNull) return Promise.all(selectors).then(notNull)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment