Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
484688a7
Commit
484688a7
authored
May 11, 2015
by
Randall Leeds
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up some try/catch with Promises
parent
fdb38397
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
15 deletions
+10
-15
guest.coffee
h/static/scripts/annotator/guest.coffee
+10
-15
No files found.
h/static/scripts/annotator/guest.coffee
View file @
484688a7
...
@@ -176,17 +176,14 @@ module.exports = class Guest extends Annotator
...
@@ -176,17 +176,14 @@ module.exports = class Guest extends Annotator
# Try to anchor all the targets
# Try to anchor all the targets
anchorTargets
=
(
targets
=
[])
=>
anchorTargets
=
(
targets
=
[])
=>
anchorPromises
=
for
target
in
targets
when
target
.
selector
for
target
in
targets
when
target
.
selector
try
Promise
.
resolve
()
this
.
anchorTarget
(
target
)
.
then
(
=>
this
.
anchorTarget
(
target
)
)
.
then
(
highlightRange
)
.
then
(
highlightRange
)
.
then
(
succeed
(
target
),
fail
(
target
))
.
then
(
succeed
(
target
),
fail
(
target
))
catch
error
Promise
.
reject
(
error
).
catch
(
fail
(
target
))
return
Promise
.
all
(
anchorPromises
).
then
(
finish
)
# Start anchoring in the background
# Start anchoring in the background
anchorTargets
(
annotation
.
target
)
Promise
.
all
(
anchorTargets
(
annotation
.
target
)).
then
(
finish
)
annotation
annotation
...
@@ -337,13 +334,11 @@ module.exports = class Guest extends Annotator
...
@@ -337,13 +334,11 @@ module.exports = class Guest extends Annotator
notNull
=
(
selectors
)
->
notNull
=
(
selectors
)
->
(
s
for
s
in
selectors
when
s
?
)
(
s
for
s
in
selectors
when
s
?
)
selectors
=
ANCHOR_TYPES
.
map
(
type
)
=>
selectors
=
for
type
in
ANCHOR_TYPES
try
promise
=
Promise
.
resolve
(
type
).
then
(
t
)
->
Promise
.
resolve
(
t
ype
.
fromRange
(
range
,
options
)).
then
(
a
)
->
Promise
.
resolve
(
t
.
fromRange
(
range
,
options
)).
then
(
a
)
->
Promise
.
resolve
(
a
.
toSelector
(
options
))
Promise
.
resolve
(
a
.
toSelector
(
options
))
,
->
null
promise
.
catch
(
->
null
)
catch
Promise
.
resolve
()
return
Promise
.
all
(
selectors
).
then
(
notNull
)
return
Promise
.
all
(
selectors
).
then
(
notNull
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment