Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
5ab492e4
Commit
5ab492e4
authored
Sep 26, 2016
by
Sean Roberts
Committed by
GitHub
Sep 26, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #136 from hypothesis/fix-direct-link-scroll
Fix scrolling to direct-linked annotations
parents
36ab62bf
d61ba101
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
widget-controller-test.js
h/static/scripts/test/widget-controller-test.js
+1
-1
widget-controller.js
h/static/scripts/widget-controller.js
+1
-1
No files found.
h/static/scripts/test/widget-controller-test.js
View file @
5ab492e4
...
@@ -271,7 +271,7 @@ describe('WidgetController', function () {
...
@@ -271,7 +271,7 @@ describe('WidgetController', function () {
};
};
annotationUI
.
addAnnotations
([
annot
]);
annotationUI
.
addAnnotations
([
annot
]);
$scope
.
$digest
();
$scope
.
$digest
();
$rootScope
.
$broadcast
(
events
.
ANNOTATIONS_SYNCED
,
[
{
tag
:
'atag'
}
]);
$rootScope
.
$broadcast
(
events
.
ANNOTATIONS_SYNCED
,
[
'atag'
]);
assert
.
calledWith
(
fakeFrameSync
.
focusAnnotations
,
[
'atag'
]);
assert
.
calledWith
(
fakeFrameSync
.
focusAnnotations
,
[
'atag'
]);
assert
.
calledWith
(
fakeFrameSync
.
scrollToAnnotation
,
'atag'
);
assert
.
calledWith
(
fakeFrameSync
.
scrollToAnnotation
,
'atag'
);
});
});
...
...
h/static/scripts/widget-controller.js
View file @
5ab492e4
...
@@ -241,7 +241,7 @@ module.exports = function WidgetController(
...
@@ -241,7 +241,7 @@ module.exports = function WidgetController(
return
;
return
;
}
}
var
matchesSelection
=
tags
.
some
(
function
(
tag
)
{
var
matchesSelection
=
tags
.
some
(
function
(
tag
)
{
return
tag
.
tag
===
selectedAnnot
.
$$tag
;
return
tag
===
selectedAnnot
.
$$tag
;
});
});
if
(
!
matchesSelection
)
{
if
(
!
matchesSelection
)
{
return
;
return
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment