Merge pull request #675 from hypothesis/hide-ap-link-for-third-party-users

Remove activity page links for third-party open groups

src/sidebar/components/group-list.js

 'use strict';
 
 var { isThirdPartyUser } = require('../util/account-id');
+var isThirdPartyService = require('../util/is-third-party-service');
 var serviceConfig = require('../service-config');
 
 // @ngInject
@@ -38,6 +39,8 @@ function GroupListController($window, analytics, groups, settings, serviceUrl) {
   if (svc && svc.icon) {
     this.thirdPartyGroupIcon = svc.icon;
   }
+
+  this.isThirdPartyService = isThirdPartyService(settings);
 }
 
 module.exports = {

src/sidebar/components/test/group-list-test.js

@@ -79,11 +79,11 @@ describe('groupList', function () {
     };
   }));
 
-  function createGroupList() {
+  function createGroupList({ userid } = { userid: 'acct:person@example.com' }) {
     return util.createDirective(document, 'groupList', {
       auth: {
-        status: 'logged-in',
-        userid: 'acct:person@example.com',
+        status: userid ? 'logged-in' : 'logged-out',
+        userid,
       },
     });
   }
@@ -105,6 +105,30 @@ describe('groupList', function () {
     assert.equal(link[1].href, GROUP_LINK);
   });
 
+  [{
+    // Logged-in third party user.
+    firstPartyAuthDomain: 'example.com',
+    authDomain: 'publisher.org',
+    userid: 'acct:person@publisher.org',
+  },{
+    // Logged-out third party user.
+    firstPartyAuthDomain: 'example.com',
+    authDomain: 'publisher.org',
+    userid: null,
+  }].forEach(({ firstPartyAuthDomain, authDomain, userid }) => {
+    it('should not render share links for third-party groups', () => {
+      fakeSettings.authDomain = firstPartyAuthDomain;
+      fakeSettings.services = [{
+        authority: authDomain,
+      }];
+
+      var element = createGroupList({ userid });
+      var shareLinks = element.find('.share-link-container');
+
+      assert.equal(shareLinks.length, 0);
+    });
+  });
+
   it('should track metrics when a user attempts to view a groups activity', function () {
     var element = createGroupList();
     var link = element.find('.share-link');

src/sidebar/templates/group-list.html

@@ -43,7 +43,7 @@
                {{group.name}}
             </a>
           </div>
-          <div class="share-link-container" ng-click="$event.stopPropagation()">
+          <div class="share-link-container" ng-click="$event.stopPropagation()" ng-if="!vm.isThirdPartyService">
             <a class="share-link"
                href="{{group.url}}"
                target="_blank"