Commit 6684d136 authored by Lyza Danger Gardner's avatar Lyza Danger Gardner Committed by Lyza Gardner

Remove unneeded GPU-acceleration class

It turns out this performance trick is no longer strictly needed for
the originally stated reason. The top bar remains cleanly fixed in
position when scrolling the page.

In Chrome the scrollable content area (the
.js-thread-list-scroll-root element) is now in its own compositing layer
anyway due to it having overflow: scroll set on it. This in turn
appears to force the browser to put the TopBar in its own compositor
layer in order to make it render above the scrollable area. When this
performance trick was originally added the whole sidebar body scrolled.
parent c0a6446f
......@@ -107,10 +107,7 @@ function TopBar({
return (
<div
className={classnames(
// This absolute-positioned top bar allows content to scroll beneath it;
// the use of `transform-gpu` can kick on hardware acceleration to make
// this smoother
'absolute h-10 left-0 top-0 right-0 z-4 transform-gpu',
'absolute h-10 left-0 top-0 right-0 z-4',
'text-grey-7 border-b theme-clean:border-b-0 bg-white'
)}
data-testid="top-bar"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment