Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
6dc9ad86
Commit
6dc9ad86
authored
Apr 13, 2020
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use `watch` utility in `frame-sync`
parent
c313ec3b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
50 additions
and
59 deletions
+50
-59
frame-sync.js
src/sidebar/services/frame-sync.js
+49
-58
frame-sync-test.js
src/sidebar/services/test/frame-sync-test.js
+1
-1
No files found.
src/sidebar/services/frame-sync.js
View file @
6dc9ad86
...
...
@@ -5,6 +5,7 @@ import events from '../events';
import
Discovery
from
'../../shared/discovery'
;
import
uiConstants
from
'../ui-constants'
;
import
*
as
metadata
from
'../util/annotation-metadata'
;
import
{
watch
}
from
'../util/watch'
;
/**
* @typedef FrameInfo
...
...
@@ -49,25 +50,17 @@ export default function FrameSync($rootScope, $window, store, bridge) {
* notify connected frames about new/updated/deleted annotations.
*/
function
setupSyncToFrame
()
{
// List of loaded annotations in previous state
let
prevAnnotations
=
[];
let
prevFrames
=
[];
let
prevPublicAnns
=
0
;
store
.
subscribe
(
function
()
{
const
state
=
store
.
getState
();
if
(
state
.
annotations
.
annotations
===
prevAnnotations
&&
state
.
frames
===
prevFrames
)
{
return
;
}
watch
(
store
.
subscribe
,
[()
=>
store
.
getState
().
annotations
.
annotations
,
()
=>
store
.
frames
()],
([
annotations
,
frames
],
[
prevAnnotations
])
=>
{
let
publicAnns
=
0
;
const
inSidebar
=
new
Set
();
const
added
=
[];
state
.
annotations
.
annotations
.
forEach
(
function
(
annot
)
{
annotations
.
forEach
(
function
(
annot
)
{
if
(
metadata
.
isReply
(
annot
))
{
// The frame does not need to know about replies
return
;
...
...
@@ -85,8 +78,6 @@ export default function FrameSync($rootScope, $window, store, bridge) {
const
deleted
=
prevAnnotations
.
filter
(
function
(
annot
)
{
return
!
inSidebar
.
has
(
annot
.
$tag
);
});
prevAnnotations
=
state
.
annotations
.
annotations
;
prevFrames
=
state
.
frames
;
// We currently only handle adding and removing annotations from the frame
// when they are added or removed in the sidebar, but not re-anchoring
...
...
@@ -102,7 +93,6 @@ export default function FrameSync($rootScope, $window, store, bridge) {
inFrame
.
delete
(
annot
.
$tag
);
});
const
frames
=
store
.
frames
();
if
(
frames
.
length
>
0
)
{
if
(
frames
.
every
(
function
(
frame
)
{
...
...
@@ -118,7 +108,8 @@ export default function FrameSync($rootScope, $window, store, bridge) {
}
}
}
});
}
);
}
/**
...
...
src/sidebar/services/test/frame-sync-test.js
View file @
6dc9ad86
...
...
@@ -55,7 +55,7 @@ describe('sidebar/services/frame-sync', function () {
beforeEach
(
function
()
{
fakeStore
=
createFakeStore
(
{
annotations
:
[]
},
{
annotations
:
{
annotations
:
[]
}
},
{
connectFrame
:
sinon
.
stub
(),
destroyFrame
:
sinon
.
stub
(),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment