Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
6fd18cc4
Commit
6fd18cc4
authored
Dec 17, 2021
by
Eduardo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply suggestions from code review
Co-authored-by:
Robert Knight
<
robertknight@gmail.com
>
parent
011eb2bd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletion
+4
-1
guest-test.js
src/annotator/test/guest-test.js
+1
-1
sidebar-test.js
src/annotator/test/sidebar-test.js
+3
-0
No files found.
src/annotator/test/guest-test.js
View file @
6fd18cc4
...
...
@@ -183,7 +183,7 @@ describe('Guest', () => {
assert
.
calledWith
(
fakeIntegration
.
fitSideBySide
,
dummyLayout
);
});
it
(
'does not call
s
fitSideBySide if `Guest` is not the main annotatable frame'
,
()
=>
{
it
(
'does not call fitSideBySide if `Guest` is not the main annotatable frame'
,
()
=>
{
createGuest
({
subFrameIdentifier
:
'dummy'
});
const
dummyLayout
=
{};
...
...
src/annotator/test/sidebar-test.js
View file @
6fd18cc4
...
...
@@ -619,14 +619,17 @@ describe('Sidebar', () => {
sidebar
.
onFrameConnected
(
'dummy'
,
port1
);
assert
.
notCalled
(
sidebarBridge
().
createChannel
);
assert
.
notCalled
(
guestBridge
().
createChannel
);
});
it
(
'create RPC channels for recognized source frames'
,
()
=>
{
const
sidebar
=
createSidebar
();
const
{
port1
}
=
new
MessageChannel
();
sidebar
.
onFrameConnected
(
'sidebar'
,
port1
);
sidebar
.
onFrameConnected
(
'guest'
,
port1
);
assert
.
calledWith
(
sidebarBridge
().
createChannel
,
port1
);
assert
.
calledWith
(
guestBridge
().
createChannel
,
port1
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment