Commit 6fd18cc4 authored by Eduardo's avatar Eduardo

Apply suggestions from code review

Co-authored-by: 's avatarRobert Knight <robertknight@gmail.com>
parent 011eb2bd
......@@ -183,7 +183,7 @@ describe('Guest', () => {
assert.calledWith(fakeIntegration.fitSideBySide, dummyLayout);
});
it('does not calls fitSideBySide if `Guest` is not the main annotatable frame', () => {
it('does not call fitSideBySide if `Guest` is not the main annotatable frame', () => {
createGuest({ subFrameIdentifier: 'dummy' });
const dummyLayout = {};
......
......@@ -619,14 +619,17 @@ describe('Sidebar', () => {
sidebar.onFrameConnected('dummy', port1);
assert.notCalled(sidebarBridge().createChannel);
assert.notCalled(guestBridge().createChannel);
});
it('create RPC channels for recognized source frames', () => {
const sidebar = createSidebar();
const { port1 } = new MessageChannel();
sidebar.onFrameConnected('sidebar', port1);
sidebar.onFrameConnected('guest', port1);
assert.calledWith(sidebarBridge().createChannel, port1);
assert.calledWith(guestBridge().createChannel, port1);
});
});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment