Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
7385c00a
Commit
7385c00a
authored
Mar 20, 2018
by
Lyza Danger Gardner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `group.public` reliance from share dialog
parent
8c279fb1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
4 deletions
+3
-4
annotation-share-dialog-test.js
src/sidebar/components/test/annotation-share-dialog-test.js
+2
-3
annotation-share-dialog.html
src/sidebar/templates/annotation-share-dialog.html
+1
-1
No files found.
src/sidebar/components/test/annotation-share-dialog-test.js
View file @
7385c00a
...
...
@@ -91,8 +91,7 @@ describe('annotationShareDialog', function () {
{
group
:
{
name
:
'Public'
,
type
:
'public'
,
public
:
true
,
type
:
'open'
,
},
uri
:
'fakeURI'
,
isPrivate
:
false
,
...
...
@@ -142,7 +141,7 @@ describe('annotationShareDialog', function () {
it
(
'is available to a group'
,
function
()
{
element
=
util
.
createDirective
(
document
,
'annotationShareDialog'
,
{
group
:
{
public
:
false
,
type
:
'private'
,
},
isPrivate
:
false
,
});
...
...
src/sidebar/templates/annotation-share-dialog.html
View file @
7385c00a
...
...
@@ -36,7 +36,7 @@
<i
class=
"h-icon-clipboard btn-icon"
></i>
</button>
</div>
<div
class=
"annotation-share-dialog-msg"
ng-if=
"vm.group &&
!vm.group.public
&& !vm.isPrivate"
>
<div
class=
"annotation-share-dialog-msg"
ng-if=
"vm.group &&
vm.group.type === 'private'
&& !vm.isPrivate"
>
<span
class=
"annotation-share-dialog-msg__audience"
>
Group.
</span>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment