Merge pull request #2128 from hypothesis/show-sidebar-label

Change show/hide sidebar button label depending on state

src/annotator/components/test/toolbar-test.js

@@ -66,7 +66,7 @@ describe('Toolbar', () => {
     assert.calledWith(toggleSidebar);
 
     wrapper.setProps({ isSidebarOpen: true });
-    findButton(wrapper, 'Show annotation sidebar').simulate('click');
+    findButton(wrapper, 'Hide annotation sidebar').simulate('click');
     assert.calledWith(toggleSidebar);
   });
 

src/annotator/components/toolbar.js

@@ -69,9 +69,12 @@ export default function Toolbar({
         <ToolbarButton
           extraClasses="annotator-frame-button--sidebar_toggle"
           buttonRef={toggleSidebarRef}
-          label="Show annotation sidebar"
+          label={
+            isSidebarOpen
+              ? 'Hide annotation sidebar'
+              : 'Show annotation sidebar'
+          }
           icon={isSidebarOpen ? 'h-icon-chevron-right' : 'h-icon-chevron-left'}
-          selected={isSidebarOpen}
           onClick={toggleSidebar}
         />
       )}