Merge pull request #489 from hypothesis/destroy-frame-mutation

Avoid mutating frames array in DESTROY_FRAME action.

Merge pull request #489 from hypothesis/destroy-frame-mutation
Avoid mutating frames array in DESTROY_FRAME action.
85225124 · Sean Roberts · GitHub · 1d0f782a · 5c90a9d3 · 85225124
Commit 85225124 authored Jul 10, 2017 by Sean Roberts Committed by GitHub Jul 10, 2017
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

frames.js src/sidebar/reducers/frames.js +3 -5

No files found.
--- a/src/sidebar/reducers/frames.js
+++ b/src/sidebar/reducers/frames.js
@@ -18,11 +18,9 @@ var update = {
  },

  DESTROY_FRAME: function (state, action) {
-    var index = state.frames.indexOf(action.frame);
-    if (index >= 0) {
-      state.frames.splice(index, 1);
-    }
-    return {frames: state.frames};
+    return {
+      frames: state.frames.filter(f => f !== action.frame),
+    };
  },

  UPDATE_FRAME_ANNOTATION_FETCH_STATUS: function (state, action) {