Commit 8cbc9978 authored by Robert Knight's avatar Robert Knight

Update an outdated comment re. `documentInfoChanged`

The sidebar now supports guests calling this RPC method multiple times,
and they do so when a client-side navigation happens. See commit
a8cff801.
parent c304f1f4
...@@ -260,10 +260,9 @@ export class FrameSyncService { ...@@ -260,10 +260,9 @@ export class FrameSyncService {
this._guestRPC.set(sourceId, guestRPC); this._guestRPC.set(sourceId, guestRPC);
// Update document metadata for this guest. We currently assume that the // Update document metadata for this guest. The guest will call this method
// guest will make this call once after it connects. To handle updates // immediately after it connects to the sidebar. It may call it again
// to the document, we'll need to change `connectFrame` to update rather than // later if the document in the guest frame is navigated.
// add to the frame list.
guestRPC.on('documentInfoChanged', (info: DocumentInfo) => { guestRPC.on('documentInfoChanged', (info: DocumentInfo) => {
this._store.connectFrame({ this._store.connectFrame({
id: sourceId, id: sourceId,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment