Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
8f641a8f
Commit
8f641a8f
authored
Oct 13, 2022
by
Lyza Danger Gardner
Committed by
Lyza Gardner
Dec 13, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update shared components in `ToastMessages`
parent
f0067816
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
31 additions
and
22 deletions
+31
-22
ToastMessages.js
src/sidebar/components/ToastMessages.js
+24
-13
ToastMessages-test.js
src/sidebar/components/test/ToastMessages-test.js
+7
-9
No files found.
src/sidebar/components/ToastMessages.js
View file @
8f641a8f
import
classnames
from
'classnames'
;
import
classnames
from
'classnames'
;
import
{
Card
,
Icon
,
Link
}
from
'@hypothesis/frontend-shared'
;
import
{
Card
,
Link
,
CancelIcon
,
CautionIcon
,
CheckIcon
,
}
from
'@hypothesis/frontend-shared/lib/next'
;
import
{
useSidebarStore
}
from
'../store'
;
import
{
useSidebarStore
}
from
'../store'
;
import
{
withServices
}
from
'../service-context'
;
import
{
withServices
}
from
'../service-context'
;
...
@@ -31,7 +37,20 @@ function ToastMessage({ message, onDismiss }) {
...
@@ -31,7 +37,20 @@ function ToastMessage({ message, onDismiss }) {
message
.
type
!==
'notice'
message
.
type
!==
'notice'
?
`
${
message
.
type
.
charAt
(
0
).
toUpperCase
()
+
message
.
type
.
slice
(
1
)}
: `
?
`
${
message
.
type
.
charAt
(
0
).
toUpperCase
()
+
message
.
type
.
slice
(
1
)}
: `
:
''
;
:
''
;
const
iconName
=
message
.
type
===
'notice'
?
'cancel'
:
message
.
type
;
let
Icon
;
switch
(
message
.
type
)
{
case
'success'
:
Icon
=
CheckIcon
;
break
;
case
'error'
:
Icon
=
CancelIcon
;
break
;
case
'notice'
:
default
:
Icon
=
CautionIcon
;
break
;
}
/**
/**
* a11y linting is disabled here: There is a click-to-remove handler on a
* a11y linting is disabled here: There is a click-to-remove handler on a
* non-interactive element. This allows sighted users to get the toast message
* non-interactive element. This allows sighted users to get the toast message
...
@@ -43,7 +62,7 @@ function ToastMessage({ message, onDismiss }) {
...
@@ -43,7 +62,7 @@ function ToastMessage({ message, onDismiss }) {
return
(
return
(
/* eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-noninteractive-element-interactions */
/* eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-noninteractive-element-interactions */
<
Card
<
Card
classes
=
{
classnames
(
'
p-0 flex border
'
,
{
classes
=
{
classnames
(
'
flex
'
,
{
'sr-only'
:
message
.
visuallyHidden
,
'sr-only'
:
message
.
visuallyHidden
,
'border-red-error'
:
message
.
type
===
'error'
,
'border-red-error'
:
message
.
type
===
'error'
,
'border-yellow-notice'
:
message
.
type
===
'notice'
,
'border-yellow-notice'
:
message
.
type
===
'notice'
,
...
@@ -59,21 +78,13 @@ function ToastMessage({ message, onDismiss }) {
...
@@ -59,21 +78,13 @@ function ToastMessage({ message, onDismiss }) {
})}
})}
>
>
<
Icon
<
Icon
name
=
{
iconName
}
className
=
{
classnames
(
classes
=
{
classnames
(
// Adjust alignment of icon to appear more aligned with text
// Adjust alignment of icon to appear more aligned with text
'mt-[2px]'
'mt-[2px]'
)}
)}
/
>
/
>
<
/div
>
<
/div
>
<
div
<
div
className
=
"grow p-3"
data
-
testid
=
"toast-message-text"
>
className
=
{
classnames
(
// TODO: After re-factoring of Card styling, `mt-0` should not need
// !important
'grow p-3 !mt-0'
)}
data
-
testid
=
"toast-message-text"
>
<
strong
>
{
prefix
}
<
/strong
>
<
strong
>
{
prefix
}
<
/strong
>
{
message
.
message
}
{
message
.
message
}
{
message
.
moreInfoURL
&&
(
{
message
.
moreInfoURL
&&
(
...
...
src/sidebar/components/test/ToastMessages-test.js
View file @
8f641a8f
...
@@ -133,12 +133,12 @@ describe('ToastMessages', () => {
...
@@ -133,12 +133,12 @@ describe('ToastMessages', () => {
});
});
[
[
{
messages
:
[
fakeSuccessMessage
()],
icons
:
[
'
success
'
]
},
{
messages
:
[
fakeSuccessMessage
()],
icons
:
[
'
CheckIcon
'
]
},
{
messages
:
[
fakeErrorMessage
()],
icons
:
[
'
error
'
]
},
{
messages
:
[
fakeErrorMessage
()],
icons
:
[
'
CancelIcon
'
]
},
{
messages
:
[
fakeNoticeMessage
()],
icons
:
[
'
cancel
'
]
},
{
messages
:
[
fakeNoticeMessage
()],
icons
:
[
'
CautionIcon
'
]
},
{
{
messages
:
[
fakeSuccessMessage
(),
fakeErrorMessage
()],
messages
:
[
fakeSuccessMessage
(),
fakeErrorMessage
()],
icons
:
[
'
success'
,
'error
'
],
icons
:
[
'
CheckIcon'
,
'CancelIcon
'
],
},
},
].
forEach
(
testCase
=>
{
].
forEach
(
testCase
=>
{
it
(
'should render an appropriate icon for the message type'
,
()
=>
{
it
(
'should render an appropriate icon for the message type'
,
()
=>
{
...
@@ -146,11 +146,9 @@ describe('ToastMessages', () => {
...
@@ -146,11 +146,9 @@ describe('ToastMessages', () => {
const
wrapper
=
createComponent
();
const
wrapper
=
createComponent
();
const
iconProps
=
wrapper
testCase
.
icons
.
forEach
(
iconName
=>
{
.
find
(
'Icon'
)
assert
.
isTrue
(
wrapper
.
find
(
iconName
).
exists
());
.
map
(
iconWrapper
=>
iconWrapper
.
props
().
name
);
});
assert
.
deepEqual
(
iconProps
,
testCase
.
icons
);
});
});
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment