Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
90be6516
Commit
90be6516
authored
Dec 15, 2014
by
Aron Carroll
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1807 from hypothesis/1799-default-public-visibility
Default to public visibility on annotations.
parents
3972fe21
6a44f65b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
privacy.coffee
h/static/scripts/directives/privacy.coffee
+1
-1
privacy-test.coffee
tests/js/directives/privacy-test.coffee
+2
-2
No files found.
h/static/scripts/directives/privacy.coffee
View file @
90be6516
...
@@ -64,7 +64,7 @@ privacy = ['$window', ($window) ->
...
@@ -64,7 +64,7 @@ privacy = ['$window', ($window) ->
controller
.
$render
=
->
controller
.
$render
=
->
unless
controller
.
$modelValue
.
read
.
length
unless
controller
.
$modelValue
.
read
.
length
name
=
storage
.
getItem
VISIBILITY_KEY
name
=
storage
.
getItem
VISIBILITY_KEY
name
?=
VISIBILITY_P
RIVATE
name
?=
VISIBILITY_P
UBLIC
level
=
getLevel
(
name
)
level
=
getLevel
(
name
)
controller
.
$setViewValue
level
controller
.
$setViewValue
level
...
...
tests/js/directives/privacy-test.coffee
View file @
90be6516
...
@@ -89,12 +89,12 @@ describe 'h.directives.privacy', ->
...
@@ -89,12 +89,12 @@ describe 'h.directives.privacy', ->
beforeEach
->
beforeEach
->
store
.
removeItem
VISIBILITY_KEY
store
.
removeItem
VISIBILITY_KEY
it
'defaults to p
rivate
'
,
->
it
'defaults to p
ublic
'
,
->
$scope
.
permissions
=
{
read
:
[]}
$scope
.
permissions
=
{
read
:
[]}
$element
=
$compile
(
'<privacy ng-model="permissions">'
)(
$scope
)
$element
=
$compile
(
'<privacy ng-model="permissions">'
)(
$scope
)
$scope
.
$digest
()
$scope
.
$digest
()
$isolateScope
=
$element
.
isolateScope
()
$isolateScope
=
$element
.
isolateScope
()
assert
.
equal
$isolateScope
.
level
.
name
,
VISIBILITY_P
RIVATE
assert
.
equal
$isolateScope
.
level
.
name
,
VISIBILITY_P
UBLIC
describe
'when permissions.read is empty'
,
->
describe
'when permissions.read is empty'
,
->
beforeEach
->
beforeEach
->
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment