Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
910e57da
Commit
910e57da
authored
Dec 07, 2017
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Stop exposing `serviceUrl` on HypothesisAppController
The template no longer uses this property.
parent
679a155c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
7 deletions
+0
-7
hypothesis-app.js
src/sidebar/components/hypothesis-app.js
+0
-2
hypothesis-app-test.js
src/sidebar/components/test/hypothesis-app-test.js
+0
-5
No files found.
src/sidebar/components/hypothesis-app.js
View file @
910e57da
...
...
@@ -57,8 +57,6 @@ function HypothesisAppController(
frameSync
.
connect
();
}
this
.
serviceUrl
=
serviceUrl
;
this
.
sortKey
=
function
()
{
return
annotationUI
.
getState
().
sortKey
;
};
...
...
src/sidebar/components/test/hypothesis-app-test.js
View file @
910e57da
...
...
@@ -265,11 +265,6 @@ describe('sidebar.components.hypothesis-app', function () {
});
});
it
(
'exposes the serviceUrl on the controller'
,
function
()
{
var
ctrl
=
createController
();
assert
.
equal
(
ctrl
.
serviceUrl
,
fakeServiceUrl
);
});
it
(
'does not show the share dialog at start'
,
function
()
{
var
ctrl
=
createController
();
assert
.
isFalse
(
ctrl
.
shareDialog
.
visible
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment