Fix error when creating annotation if groups are not loaded

Fix an old crash [1] when attempting to create an annotation if groups have not
yet loaded. In this case there is no focused group for the new annotation to be
associated with.

The handling for now is to just ignore the request and delete the highlight in
the guest, similar to how we handle the case where the user is not logged in,
except we don't show the login panel.

[1] https://hypothesis.sentry.io/issues/4412536210/

src/sidebar/services/frame-sync.ts

@@ -388,16 +388,22 @@ export class FrameSyncService {
 
     // A new annotation, note or highlight was created in the frame
     guestRPC.on('createAnnotation', (annot: AnnotationData) => {
-      // If user is not logged in, we can't really create a meaningful highlight
-      // or annotation. Instead, we need to open the sidebar, show an error,
-      // and delete the (unsaved) annotation so it gets un-selected in the
-      // target document
-      if (!this._store.isLoggedIn()) {
+      // If user is not logged in, or groups haven't loaded yet, we can't create
+      // a meaningful highlight or annotation. Instead, we need to open the
+      // sidebar, show an error, and delete the (unsaved) annotation so it gets
+      // un-selected in the target document
+      const isLoggedIn = this._store.isLoggedIn();
+      const hasGroup = this._store.focusedGroup() !== null;
+
+      if (!isLoggedIn || !hasGroup) {
         this._hostRPC.call('openSidebar');
+        if (!isLoggedIn) {
           this._store.openSidebarPanel('loginPrompt');
+        }
         this._guestRPC.forEach(rpc => rpc.call('deleteAnnotation', annot.$tag));
         return;
       }
+
       this._inFrame.add(annot.$tag);
 
       // Open the sidebar so that the user can immediately edit the draft

src/sidebar/services/test/frame-sync-test.js

@@ -149,6 +149,7 @@ describe('FrameSyncService', () => {
         },
 
         findIDsForTags: sinon.stub().returns([]),
+        focusedGroup: sinon.stub().returns({ id: 'foobar' }),
         hoverAnnotations: sinon.stub(),
         isLoggedIn: sinon.stub().returns(false),
         openSidebarPanel: sinon.stub(),
@@ -583,7 +584,7 @@ describe('FrameSyncService', () => {
       assert.calledWith(hostRPC().call, 'showHighlights');
     });
 
-    context('when an authenticated user is present', () => {
+    context('user is logged in and there is a focused group', () => {
       beforeEach(async () => {
         frameSync.connect();
         await connectGuest();
@@ -619,13 +620,7 @@ describe('FrameSyncService', () => {
       });
     });
 
-    context('when no authenticated user is present', () => {
-      beforeEach(async () => {
-        fakeStore.isLoggedIn.returns(false);
-        frameSync.connect();
-        await connectGuest();
-      });
-
+    const addCommonNotReadyTests = () => {
       it('should not create an annotation in the sidebar', () => {
         emitGuestEvent('createAnnotation', { $tag: 't1', target: [] });
 
@@ -638,17 +633,38 @@ describe('FrameSyncService', () => {
         assert.calledWith(hostRPC().call, 'openSidebar');
       });
 
-      it('should open the login prompt panel', () => {
+      it('should send a "deleteAnnotation" message to the frame', () => {
         emitGuestEvent('createAnnotation', { $tag: 't1', target: [] });
 
-        assert.calledWith(fakeStore.openSidebarPanel, 'loginPrompt');
+        assert.calledWith(guestRPC().call, 'deleteAnnotation');
       });
+    };
 
-      it('should send a "deleteAnnotation" message to the frame', () => {
+    context('user is not logged in', () => {
+      beforeEach(async () => {
+        fakeStore.isLoggedIn.returns(false);
+        frameSync.connect();
+        await connectGuest();
+      });
+
+      addCommonNotReadyTests();
+
+      it('should open the login prompt panel', () => {
         emitGuestEvent('createAnnotation', { $tag: 't1', target: [] });
 
-        assert.calledWith(guestRPC().call, 'deleteAnnotation');
+        assert.calledWith(fakeStore.openSidebarPanel, 'loginPrompt');
+      });
     });
+
+    context('groups have not loaded', () => {
+      beforeEach(async () => {
+        fakeStore.isLoggedIn.returns(true);
+        fakeStore.focusedGroup.returns(null);
+        frameSync.connect();
+        await connectGuest();
+      });
+
+      addCommonNotReadyTests();
     });
   });