Commit a5698b9c authored by Kyle Keating's avatar Kyle Keating Committed by Robert Knight

Revert Button `onClick` requiredness

This causes several issues and its not immediately clear this needs or should be required
parent 17b8ce10
...@@ -21,7 +21,7 @@ import SvgIcon from '../../shared/components/svg-icon'; ...@@ -21,7 +21,7 @@ import SvgIcon from '../../shared/components/svg-icon';
* @prop {boolean} [isPressed] - * @prop {boolean} [isPressed] -
* Indicate that this is a toggle button (if `isPressed` is a boolean) and whether it * Indicate that this is a toggle button (if `isPressed` is a boolean) and whether it
* is pressed. If omitted, the button is a non-toggle button. * is pressed. If omitted, the button is a non-toggle button.
* @prop {(e: Event) => any} onClick - callback for button clicks * @prop {(e: Event) => any} [onClick] - callback for button clicks
* @prop {boolean} [disabled] - disables the button when true * @prop {boolean} [disabled] - disables the button when true
* @prop {Object} [style] - optional inline styling * @prop {Object} [style] - optional inline styling
* @prop {string} [title] - * @prop {string} [title] -
...@@ -112,7 +112,7 @@ Button.propTypes = { ...@@ -112,7 +112,7 @@ Button.propTypes = {
icon: requiredStringIfButtonTextMissing, icon: requiredStringIfButtonTextMissing,
isExpanded: propTypes.bool, isExpanded: propTypes.bool,
isPressed: propTypes.bool, isPressed: propTypes.bool,
onClick: propTypes.func.isRequired, onClick: propTypes.func,
disabled: propTypes.bool, disabled: propTypes.bool,
style: propTypes.object, style: propTypes.object,
title: requiredStringIfButtonTextMissing, title: requiredStringIfButtonTextMissing,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment