Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
b2e86aaf
Commit
b2e86aaf
authored
Jan 24, 2017
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Whitelist and document 'appType' parameter
parent
0d95508e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
host-config.js
src/sidebar/host-config.js
+4
-0
host-config-test.js
src/sidebar/test/host-config-test.js
+2
-0
No files found.
src/sidebar/host-config.js
View file @
b2e86aaf
...
...
@@ -17,6 +17,10 @@ function hostPageConfig(window) {
// Direct-linked annotation ID
'annotations'
,
// Config param added by the extension, Via etc. indicating how Hypothesis
// was added to the page.
'appType'
,
// Config params documented at
// https://github.com/hypothesis/client/blob/master/docs/config.md
'openLoginForm'
,
...
...
src/sidebar/test/host-config-test.js
View file @
b2e86aaf
...
...
@@ -14,6 +14,7 @@ describe('hostPageConfig', function () {
it
(
'parses config from location string and returns whitelisted params'
,
function
()
{
var
window_
=
fakeWindow
({
annotations
:
'1234'
,
appType
:
'bookmarklet'
,
openSidebar
:
true
,
openLoginForm
:
true
,
showHighlights
:
true
,
...
...
@@ -21,6 +22,7 @@ describe('hostPageConfig', function () {
assert
.
deepEqual
(
hostPageConfig
(
window_
),
{
annotations
:
'1234'
,
appType
:
'bookmarklet'
,
openSidebar
:
true
,
openLoginForm
:
true
,
showHighlights
:
true
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment