Commit b34060fa authored by Alejandro Celaya's avatar Alejandro Celaya Committed by Alejandro Celaya

Update to frontend-shared 7.0.1

parent 11dacc56
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
"@babel/preset-react": "^7.0.0", "@babel/preset-react": "^7.0.0",
"@babel/preset-typescript": "^7.16.7", "@babel/preset-typescript": "^7.16.7",
"@hypothesis/frontend-build": "^3.0.0", "@hypothesis/frontend-build": "^3.0.0",
"@hypothesis/frontend-shared": "^6.10.0", "@hypothesis/frontend-shared": "^7.0.1",
"@hypothesis/frontend-testing": "^1.2.0", "@hypothesis/frontend-testing": "^1.2.0",
"@npmcli/arborist": "^7.0.0", "@npmcli/arborist": "^7.0.0",
"@octokit/rest": "^20.0.1", "@octokit/rest": "^20.0.1",
......
...@@ -8,7 +8,7 @@ import { ...@@ -8,7 +8,7 @@ import {
NoteIcon, NoteIcon,
ShowIcon, ShowIcon,
} from '@hypothesis/frontend-shared'; } from '@hypothesis/frontend-shared';
import type { ButtonCommonProps } from '@hypothesis/frontend-shared/lib/components/input/ButtonBase'; import type { ButtonProps } from '@hypothesis/frontend-shared/lib/components/input/Button';
import type { import type {
IconComponent, IconComponent,
PresentationalProps, PresentationalProps,
...@@ -19,7 +19,7 @@ import type { JSX, RefObject } from 'preact'; ...@@ -19,7 +19,7 @@ import type { JSX, RefObject } from 'preact';
// TODO: ToolbarButton should be extracted as a shared design pattern or // TODO: ToolbarButton should be extracted as a shared design pattern or
// component // component
type ToolbarButtonProps = PresentationalProps & type ToolbarButtonProps = PresentationalProps &
ButtonCommonProps & ButtonProps &
Omit<JSX.HTMLAttributes<HTMLButtonElement>, 'icon' | 'size'> & { Omit<JSX.HTMLAttributes<HTMLButtonElement>, 'icon' | 'size'> & {
icon: IconComponent; icon: IconComponent;
}; };
......
...@@ -3,7 +3,7 @@ import { ...@@ -3,7 +3,7 @@ import {
ArrowLeftIcon, ArrowLeftIcon,
ArrowRightIcon, ArrowRightIcon,
} from '@hypothesis/frontend-shared'; } from '@hypothesis/frontend-shared';
import type { ButtonCommonProps } from '@hypothesis/frontend-shared/lib/components/input/ButtonBase'; import type { ButtonProps } from '@hypothesis/frontend-shared/lib/components/input/Button';
import type { PresentationalProps } from '@hypothesis/frontend-shared/lib/types'; import type { PresentationalProps } from '@hypothesis/frontend-shared/lib/types';
import classnames from 'classnames'; import classnames from 'classnames';
import type { JSX } from 'preact'; import type { JSX } from 'preact';
...@@ -11,7 +11,7 @@ import type { JSX } from 'preact'; ...@@ -11,7 +11,7 @@ import type { JSX } from 'preact';
import { pageNumberOptions } from '../util/pagination'; import { pageNumberOptions } from '../util/pagination';
type NavigationButtonProps = PresentationalProps & type NavigationButtonProps = PresentationalProps &
ButtonCommonProps & ButtonProps &
Omit<JSX.HTMLAttributes<HTMLButtonElement>, 'icon' | 'size'>; Omit<JSX.HTMLAttributes<HTMLButtonElement>, 'icon' | 'size'>;
function NavigationButton({ ...buttonProps }: NavigationButtonProps) { function NavigationButton({ ...buttonProps }: NavigationButtonProps) {
......
...@@ -193,18 +193,15 @@ export default function SearchInput({ ...@@ -193,18 +193,15 @@ export default function SearchInput({
<IconButton <IconButton
icon={SearchIcon} icon={SearchIcon}
onClick={() => input.current?.focus()} onClick={() => input.current?.focus()}
size="xs"
title="Search annotations" title="Search annotations"
// The containing form has a white background. The top bar is only // The containing form has a white background. The top bar is only
// 40px high. If we allow standard touch-minimum height here (44px), // 40px high. If we allow standard touch-minimum height here (44px),
// the visible white background exceeds the height of the top bar in // the visible white background exceeds the height of the top bar in
// touch contexts. Disable touch sizing, then add back the width // touch contexts. Disable touch sizing via `size="custom"`, then
// rule to keep horizontal spacing consistent. // add back the width rule and padding to keep horizontal spacing
// FIXME: // consistent.
// Button/IconButton are due a pass for responsive styling and size="custom"
// appropriate styling API controls (@hypothesis/frontend-shared) classes="touch:min-w-touch-minimum p-1"
disableTouchSizing
classes="touch:min-w-touch-minimum"
/> />
</div> </div>
)} )}
......
...@@ -24,12 +24,6 @@ export default { ...@@ -24,12 +24,6 @@ export default {
'pulse-fade-out': 'pulse-fade-out 5s ease-in-out forwards', 'pulse-fade-out': 'pulse-fade-out 5s ease-in-out forwards',
'slide-in-from-right': 'slide-in-from-right 0.3s forwards ease-in-out', 'slide-in-from-right': 'slide-in-from-right 0.3s forwards ease-in-out',
}, },
borderRadius: {
// Equivalent to tailwind defaults, but overriding values from frontend-shared preset
// Once the preset stops defining borderRadius, we can remove this
DEFAULT: '0.25rem',
lg: '0.5rem',
},
boxShadow: { boxShadow: {
// A more prominent shadow than the one used by tailwind, intended for // A more prominent shadow than the one used by tailwind, intended for
// popovers and menus // popovers and menus
......
...@@ -1905,15 +1905,15 @@ __metadata: ...@@ -1905,15 +1905,15 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"@hypothesis/frontend-shared@npm:^6.10.0": "@hypothesis/frontend-shared@npm:^7.0.1":
version: 6.12.0 version: 7.0.1
resolution: "@hypothesis/frontend-shared@npm:6.12.0" resolution: "@hypothesis/frontend-shared@npm:7.0.1"
dependencies: dependencies:
highlight.js: ^11.6.0 highlight.js: ^11.6.0
wouter-preact: ^2.10.0-alpha.1 wouter-preact: ^2.10.0-alpha.1
peerDependencies: peerDependencies:
preact: ^10.4.0 preact: ^10.4.0
checksum: c679a7ffc0265a6eb0394e2a5c0e39b381875f47d84e1b17922e3148f0fcd190584c9627a000467382ae1cdeea07931027407ce1f81a76ddec39d59d6f0b07a3 checksum: 9e010f87f175783e46a258ba95fe4a381091aeb8c7a229745867af5a6d9603a50fe7da407f531c935e0eb471479a3d7d44983b3afad138ce8d38507ecded6acf
languageName: node languageName: node
linkType: hard linkType: hard
...@@ -7681,7 +7681,7 @@ __metadata: ...@@ -7681,7 +7681,7 @@ __metadata:
"@babel/preset-react": ^7.0.0 "@babel/preset-react": ^7.0.0
"@babel/preset-typescript": ^7.16.7 "@babel/preset-typescript": ^7.16.7
"@hypothesis/frontend-build": ^3.0.0 "@hypothesis/frontend-build": ^3.0.0
"@hypothesis/frontend-shared": ^6.10.0 "@hypothesis/frontend-shared": ^7.0.1
"@hypothesis/frontend-testing": ^1.2.0 "@hypothesis/frontend-testing": ^1.2.0
"@npmcli/arborist": ^7.0.0 "@npmcli/arborist": ^7.0.0
"@octokit/rest": ^20.0.1 "@octokit/rest": ^20.0.1
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment