Fix incorrect usage of Sinon APIs

 - Fix cases where `sinon.spy` was used where `sinon.stub` should have
   been used. In recent versions of Sinon only stubs have a `reset`
   method.
 - Fix use of `sinon.stub` as object instead of function

src/annotator/test/sidebar-test.coffee

@@ -328,7 +328,7 @@ describe 'Sidebar', ->
       sidebar = null
       frame = null
       beforeEach ->
-        layoutChangeHandlerSpy = sandbox.spy()
+        layoutChangeHandlerSpy = sandbox.stub()
         sidebar = createSidebar { onLayoutChange: layoutChangeHandlerSpy, sidebarAppUrl: '/' }
 
         # remove info about call that happens on creation of sidebar
@@ -391,7 +391,7 @@ describe 'Sidebar', ->
         }
         document.body.appendChild externalFrame
 
-        layoutChangeHandlerSpy = sandbox.spy()
+        layoutChangeHandlerSpy = sandbox.stub()
         layoutChangeExternalConfig = {
           onLayoutChange: layoutChangeHandlerSpy,
           sidebarAppUrl: '/',
@@ -444,4 +444,4 @@ describe 'Sidebar', ->
     it 'does not have the BucketBar or Toolbar plugin if an external container is provided', ->
       sidebar = createSidebar({ externalContainerSelector: '.' + EXTERNAL_CONTAINER_SELECTOR })
       assert.isUndefined(sidebar.plugins.BucketBar)
-      assert.isUndefined(sidebar.plugins.Toolbar)
\ No newline at end of file
+      assert.isUndefined(sidebar.plugins.Toolbar)

src/sidebar/components/test/sidebar-content-test.js

@@ -82,8 +82,8 @@ describe('sidebar.components.sidebar-content', function () {
     };
 
     fakeAnnotationMapper = {
-      loadAnnotations: sandbox.spy(),
-      unloadAnnotations: sandbox.spy(),
+      loadAnnotations: sandbox.stub(),
+      unloadAnnotations: sandbox.stub(),
     };
 
     fakeFrameSync = {
@@ -100,9 +100,9 @@ describe('sidebar.components.sidebar-content', function () {
     };
 
     fakeStreamer = {
-      setConfig: sandbox.spy(),
-      connect: sandbox.spy(),
-      reconnect: sandbox.spy(),
+      setConfig: sandbox.stub(),
+      connect: sandbox.stub(),
+      reconnect: sandbox.stub(),
     };
 
     fakeStreamFilter = {

src/sidebar/services/test/local-storage-test.js

@@ -14,7 +14,7 @@ function windowWithLocalStoragePropertyThatThrows() {
 }
 
 function windowWithLocalStorageMethodsThatThrow() {
-  const throwErr = sinon.stub.throws(new Error('Denied'));
+  const throwErr = sinon.stub().throws(new Error('Denied'));
 
   return {
     localStorage: {