Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
bdcb3c23
Commit
bdcb3c23
authored
Feb 20, 2024
by
Alejandro Celaya
Committed by
Alejandro Celaya
Feb 23, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add accessible names to profile and notebook dialogs
parent
3e8d9d68
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
1 deletion
+6
-1
ModalDialog.tsx
src/annotator/components/ModalDialog.tsx
+3
-0
NotebookModal.tsx
src/annotator/components/NotebookModal.tsx
+2
-1
ProfileModal.tsx
src/annotator/components/ProfileModal.tsx
+1
-0
No files found.
src/annotator/components/ModalDialog.tsx
View file @
bdcb3c23
...
...
@@ -7,6 +7,7 @@ type DialogProps = {
children
:
ComponentChildren
;
onClose
:
()
=>
void
;
'data-testid'
?:
string
;
'aria-label'
?:
string
;
};
function
NativeDialog
({
...
...
@@ -14,6 +15,7 @@ function NativeDialog({
onClose
,
children
,
'data-testid'
:
testId
,
'aria-label'
:
label
,
}:
DialogProps
)
{
const
dialogRef
=
useRef
<
HTMLDialogElement
|
null
>
(
null
);
...
...
@@ -39,6 +41,7 @@ function NativeDialog({
ref=
{
dialogRef
}
className=
"relative w-full h-full backdrop:bg-black/50"
data
-
testid=
{
testId
}
aria
-
label=
{
label
}
>
{
children
}
</
dialog
>
...
...
src/annotator/components/NotebookModal.tsx
View file @
bdcb3c23
...
...
@@ -112,10 +112,11 @@ export default function NotebookModal({
closed=
{
isHidden
}
onClose=
{
onClose
}
data
-
testid=
"notebook-outer"
aria
-
label=
"Hypothesis notebook"
>
<
div
className=
"absolute right-0 m-3"
>
<
IconButton
title=
"Close
the N
otebook"
title=
"Close
n
otebook"
onClick=
{
onClose
}
variant=
"dark"
classes=
{
classnames
(
...
...
src/annotator/components/ProfileModal.tsx
View file @
bdcb3c23
...
...
@@ -42,6 +42,7 @@ export default function ProfileModal({ eventBus, config }: ProfileModalProps) {
closed=
{
isHidden
}
onClose=
{
onClose
}
data
-
testid=
"profile-outer"
aria
-
label=
"Hypothesis profile"
>
<
div
className=
"absolute right-0 m-3"
>
<
IconButton
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment