Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
be001f85
Commit
be001f85
authored
May 20, 2020
by
Lyza Danger Gardner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove redundant “Select” and “tabs” verbiage
parent
3ba68201
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
9 deletions
+9
-9
selection-tabs.js
src/sidebar/components/selection-tabs.js
+3
-3
selection-tabs-test.js
src/sidebar/components/test/selection-tabs-test.js
+6
-6
No files found.
src/sidebar/components/selection-tabs.js
View file @
be001f85
...
@@ -123,7 +123,7 @@ function SelectionTabs({ isLoading, settings }) {
...
@@ -123,7 +123,7 @@ function SelectionTabs({ isLoading, settings }) {
count
=
{
annotationCount
}
count
=
{
annotationCount
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_ANNOTATIONS
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_ANNOTATIONS
}
label
=
"
Select annotations tab
"
label
=
"
Annotations
"
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_ANNOTATIONS
)}
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_ANNOTATIONS
)}
>
>
Annotations
Annotations
...
@@ -132,7 +132,7 @@ function SelectionTabs({ isLoading, settings }) {
...
@@ -132,7 +132,7 @@ function SelectionTabs({ isLoading, settings }) {
count
=
{
noteCount
}
count
=
{
noteCount
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_NOTES
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_NOTES
}
label
=
"
Select page notes tab
"
label
=
"
Page notes
"
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_NOTES
)}
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_NOTES
)}
>
>
Page
Notes
Page
Notes
...
@@ -142,7 +142,7 @@ function SelectionTabs({ isLoading, settings }) {
...
@@ -142,7 +142,7 @@ function SelectionTabs({ isLoading, settings }) {
count
=
{
orphanCount
}
count
=
{
orphanCount
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isWaitingToAnchor
=
{
isWaitingToAnchorAnnotations
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_ORPHANS
}
isSelected
=
{
selectedTab
===
uiConstants
.
TAB_ORPHANS
}
label
=
"
Select orphans tab
"
label
=
"
Orphans
"
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_ORPHANS
)}
onSelect
=
{()
=>
selectTab
(
uiConstants
.
TAB_ORPHANS
)}
>
>
Orphans
Orphans
...
...
src/sidebar/components/test/selection-tabs-test.js
View file @
be001f85
...
@@ -112,12 +112,12 @@ describe('SelectionTabs', function () {
...
@@ -112,12 +112,12 @@ describe('SelectionTabs', function () {
const
tabs
=
wrapper
.
find
(
'button'
);
const
tabs
=
wrapper
.
find
(
'button'
);
assert
.
equal
(
tabs
.
at
(
0
).
prop
(
'aria-label'
),
'
Select annotations tab
'
);
assert
.
equal
(
tabs
.
at
(
0
).
prop
(
'aria-label'
),
'
Annotations
'
);
assert
.
equal
(
tabs
.
at
(
0
).
prop
(
'title'
),
'
Select annotations tab
'
);
assert
.
equal
(
tabs
.
at
(
0
).
prop
(
'title'
),
'
Annotations
'
);
assert
.
equal
(
tabs
.
at
(
1
).
prop
(
'aria-label'
),
'
Select page notes tab
'
);
assert
.
equal
(
tabs
.
at
(
1
).
prop
(
'aria-label'
),
'
Page notes
'
);
assert
.
equal
(
tabs
.
at
(
1
).
prop
(
'title'
),
'
Select page notes tab
'
);
assert
.
equal
(
tabs
.
at
(
1
).
prop
(
'title'
),
'
Page notes
'
);
assert
.
equal
(
tabs
.
at
(
2
).
prop
(
'aria-label'
),
'
Select orphans tab
'
);
assert
.
equal
(
tabs
.
at
(
2
).
prop
(
'aria-label'
),
'
Orphans
'
);
assert
.
equal
(
tabs
.
at
(
2
).
prop
(
'title'
),
'
Select orphans tab
'
);
assert
.
equal
(
tabs
.
at
(
2
).
prop
(
'title'
),
'
Orphans
'
);
});
});
it
(
'should show the clean theme when settings contains the clean theme option'
,
function
()
{
it
(
'should show the clean theme when settings contains the clean theme option'
,
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment