Unverified Commit c5642ed2 authored by Lyza Gardner's avatar Lyza Gardner Committed by GitHub

Merge pull request #1985 from hypothesis/annotation-semantic-elements

Adjust some HTML semantic structural elements
parents e5777d43 7586d1bf
...@@ -92,8 +92,8 @@ function Annotation({ ...@@ -92,8 +92,8 @@ function Annotation({
const onToggleReplies = () => setCollapsed(annotation.id, !threadIsCollapsed); const onToggleReplies = () => setCollapsed(annotation.id, !threadIsCollapsed);
return ( return (
/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */ /* eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions */
<div <article
className={classnames('annotation', { className={classnames('annotation', {
'annotation--reply': isReply(annotation), 'annotation--reply': isReply(annotation),
'is-collapsed': threadIsCollapsed, 'is-collapsed': threadIsCollapsed,
...@@ -144,7 +144,7 @@ function Annotation({ ...@@ -144,7 +144,7 @@ function Annotation({
)} )}
</div> </div>
</footer> </footer>
</div> </article>
); );
} }
......
...@@ -42,7 +42,7 @@ function Thread({ showDocumentInfo = false, thread, threadsService }) { ...@@ -42,7 +42,7 @@ function Thread({ showDocumentInfo = false, thread, threadsService }) {
const onToggleReplies = () => setCollapsed(thread.id, !thread.collapsed); const onToggleReplies = () => setCollapsed(thread.id, !thread.collapsed);
return ( return (
<div <section
className={classnames('thread', { className={classnames('thread', {
'thread--reply': thread.depth > 0, 'thread--reply': thread.depth > 0,
'is-collapsed': thread.collapsed, 'is-collapsed': thread.collapsed,
...@@ -96,7 +96,7 @@ function Thread({ showDocumentInfo = false, thread, threadsService }) { ...@@ -96,7 +96,7 @@ function Thread({ showDocumentInfo = false, thread, threadsService }) {
</ul> </ul>
)} )}
</div> </div>
</div> </section>
); );
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment