Add and update tests for JSTOR content banner

src/annotator/components/ContentPartnerBanner.js

@@ -29,7 +29,9 @@ export default function ContentPartnerBanner({ provider, onClose }) {
         </>
       )}
       <div className="text-annotator-base">
-        <LabeledButton onClick={onClose}>Close</LabeledButton>
+        <LabeledButton onClick={onClose} data-testid="close-button">
+          Close
+        </LabeledButton>
       </div>
     </div>
   );

src/annotator/components/test/ContentPartnerBanner-test.js

+import { mount } from 'enzyme';
+
+import ContentPartnerBanner from '../ContentPartnerBanner';
+
+describe('ContentPartnerBanner', () => {
+  it('renders JSTOR banner', () => {
+    const wrapper = mount(<ContentPartnerBanner provider="jstor" />);
+    assert.include(wrapper.text(), 'Document hosted by JSTOR');
+  });
+
+  it('closes when "Close" button is clicked', () => {
+    const onClose = sinon.stub();
+    const wrapper = mount(
+      <ContentPartnerBanner provider="jstor" onClose={onClose} />
+    );
+    const closeButton = wrapper.find(
+      'LabeledButton[data-testid="close-button"]'
+    );
+
+    closeButton.prop('onClick')();
+
+    assert.calledOnce(onClose);
+  });
+});

src/annotator/config/test/index-test.js

@@ -77,6 +77,7 @@ describe('annotator/config/index', () => {
             annotations: 'fakeValue',
             branding: null,
             clientUrl: 'fakeValue',
+            contentPartner: null,
             enableExperimentalNewNoteButton: null,
             externalContainerSelector: null,
             focus: null,
@@ -108,6 +109,7 @@ describe('annotator/config/index', () => {
             annotations: 'fakeValue',
             branding: 'fakeValue',
             clientUrl: 'fakeValue',
+            contentPartner: 'fakeValue',
             enableExperimentalNewNoteButton: 'fakeValue',
             externalContainerSelector: 'fakeValue',
             focus: 'fakeValue',
@@ -163,6 +165,7 @@ describe('annotator/config/index', () => {
         annotations: null,
         branding: null,
         clientUrl: null,
+        contentPartner: null,
         enableExperimentalNewNoteButton: null,
         externalContainerSelector: null,
         focus: null,
@@ -217,7 +220,7 @@ describe('annotator/config/index', () => {
     [
       {
         app: 'annotator',
-        expectedKeys: ['clientUrl', 'subFrameIdentifier'],
+        expectedKeys: ['clientUrl', 'contentPartner', 'subFrameIdentifier'],
       },
       {
         app: 'sidebar',

src/annotator/integrations/test/index-test.js

@@ -39,6 +39,19 @@ describe('createIntegration', () => {
     assert.instanceOf(integration, FakePDFIntegration);
   });
 
+  it('passes options to PDF integration', () => {
+    const annotator = {};
+    fakeIsPDF.returns(true);
+
+    createIntegration(annotator, {
+      contentPartner: 'jstor',
+    });
+
+    assert.calledWith(FakePDFIntegration, annotator, {
+      contentPartner: 'jstor',
+    });
+  });
+
   it('creates VitalSource content integration in the VS Bookshelf reader', () => {
     const annotator = {};
     fakeVitalSourceFrameRole.returns('content');

src/annotator/integrations/test/pdf-test.js

@@ -214,7 +214,7 @@ describe('annotator/integrations/pdf', () => {
       });
     });
 
-    function getWarningBanner() {
+    function getBanner() {
       return document.querySelector('hypothesis-banner');
     }
 
@@ -225,7 +225,7 @@ describe('annotator/integrations/pdf', () => {
       await delay(0); // Wait for text check to complete.
 
       assert.called(fakePDFAnchoring.documentHasText);
-      assert.isNull(getWarningBanner());
+      assert.isNull(getBanner());
     });
 
     it('does not show a warning if PDF does not load', async () => {
@@ -235,7 +235,7 @@ describe('annotator/integrations/pdf', () => {
       await delay(0); // Wait for text check to complete.
 
       assert.notCalled(fakePDFAnchoring.documentHasText);
-      assert.isNull(getWarningBanner());
+      assert.isNull(getBanner());
     });
 
     it('shows a warning when PDF has no selectable text', async () => {
@@ -245,7 +245,7 @@ describe('annotator/integrations/pdf', () => {
       await delay(0); // Wait for text check to complete.
 
       assert.called(fakePDFAnchoring.documentHasText);
-      const banner = getWarningBanner();
+      const banner = getBanner();
       assert.isNotNull(banner);
       assert.include(
         banner.shadowRoot.textContent,
@@ -253,6 +253,25 @@ describe('annotator/integrations/pdf', () => {
       );
     });
 
+    it('shows banner when content is provided by JSTOR', () => {
+      pdfIntegration = createPDFIntegration({ contentPartner: 'jstor' });
+      const banner = getBanner();
+      assert.isNotNull(banner);
+      assert.include(banner.shadowRoot.textContent, 'Document hosted by JSTOR');
+    });
+
+    it('closes content partner banner when "Close" button is clicked', () => {
+      pdfIntegration = createPDFIntegration({ contentPartner: 'jstor' });
+      const banner = getBanner();
+      const closeButton = banner.shadowRoot.querySelector(
+        'button[data-testid=close-button]'
+      );
+
+      closeButton.click();
+
+      assert.isNull(getBanner());
+    });
+
     context('when the PDF viewer content changes', () => {
       async function triggerUpdate() {
         const element = document.createElement('div');

src/annotator/test/guest-test.js

@@ -1248,6 +1248,22 @@ describe('Guest', () => {
     assert.calledWith(sidebarRPC().connect, port1);
   });
 
+  it('passes configuration to integration', () => {
+    const config = {
+      // Configuration options that should be forwarded to the integration
+      contentPartner: 'jstor',
+      // Other configuration
+      otherOption: 'test',
+    };
+
+    const guest = createGuest(config);
+
+    assert.calledOnce(fakeCreateIntegration);
+    assert.calledWith(fakeCreateIntegration, guest, {
+      contentPartner: 'jstor',
+    });
+  });
+
   it('configures the BucketBarClient', () => {
     const contentContainer = document.createElement('div');
     fakeIntegration.contentContainer.returns(contentContainer);