Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
d4f92459
Commit
d4f92459
authored
Mar 01, 2021
by
Eduardo Sanz García
Committed by
Eduardo
Mar 01, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ResizeObserver is now defined in the latest TS version
Removed @ts-ignore
parent
c7778a94
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
5 deletions
+0
-5
pdf.js
src/annotator/plugin/pdf.js
+0
-3
observe-element-size.js
src/sidebar/util/observe-element-size.js
+0
-2
No files found.
src/annotator/plugin/pdf.js
View file @
d4f92459
...
@@ -172,12 +172,9 @@ export default class PDF extends Delegator {
...
@@ -172,12 +172,9 @@ export default class PDF extends Delegator {
// nb. In browsers that don't support `ResizeObserver` the banner height
// nb. In browsers that don't support `ResizeObserver` the banner height
// will simply be static and not adjust if the window is resized.
// will simply be static and not adjust if the window is resized.
//
// @ts-expect-error - TS is missing `ResizeObserver`
if
(
typeof
ResizeObserver
!==
'undefined'
)
{
if
(
typeof
ResizeObserver
!==
'undefined'
)
{
// Update the banner when the window is resized or the Hypothesis
// Update the banner when the window is resized or the Hypothesis
// sidebar is opened.
// sidebar is opened.
// @ts-ignore
new
ResizeObserver
(
updateBannerHeight
).
observe
(
this
.
_warningBanner
);
new
ResizeObserver
(
updateBannerHeight
).
observe
(
this
.
_warningBanner
);
}
}
updateBannerHeight
();
updateBannerHeight
();
...
...
src/sidebar/util/observe-element-size.js
View file @
d4f92459
...
@@ -12,9 +12,7 @@
...
@@ -12,9 +12,7 @@
* @return {() => void}
* @return {() => void}
*/
*/
export
default
function
observeElementSize
(
element
,
onSizeChanged
)
{
export
default
function
observeElementSize
(
element
,
onSizeChanged
)
{
// @ts-ignore - TS is missing `ResizeObserver` type definition
if
(
typeof
ResizeObserver
!==
'undefined'
)
{
if
(
typeof
ResizeObserver
!==
'undefined'
)
{
// @ts-ignore
const
observer
=
new
ResizeObserver
(()
=>
const
observer
=
new
ResizeObserver
(()
=>
onSizeChanged
(
element
.
clientWidth
,
element
.
clientHeight
)
onSizeChanged
(
element
.
clientWidth
,
element
.
clientHeight
)
);
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment