Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
e4be6357
Commit
e4be6357
authored
Nov 28, 2014
by
Aron Carroll
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1733 from hypothesis/consistent-naming
Consistent names for focusing on annotations.
parents
c94a438f
26de2224
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
controllers.coffee
h/static/scripts/controllers.coffee
+3
-3
guest.coffee
h/static/scripts/guest.coffee
+1
-1
viewer.html
h/templates/client/viewer.html
+2
-2
No files found.
h/static/scripts/controllers.coffee
View file @
e4be6357
...
...
@@ -305,7 +305,7 @@ class AnnotationViewerController
# Provide no-ops until these methods are moved elsewere. They only apply
# to annotations loaded into the stream.
$scope
.
activate
=
angular
.
noop
$scope
.
focus
=
angular
.
noop
$scope
.
shouldShowThread
=
->
true
...
...
@@ -335,14 +335,14 @@ class ViewerController
$scope
.
isEmbedded
=
true
$scope
.
isStream
=
true
$scope
.
activate
=
(
annotation
)
->
$scope
.
focus
=
(
annotation
)
->
if
angular
.
isObject
annotation
highlights
=
[
annotation
.
$
$tag
]
else
highlights
=
[]
for
p
in
annotator
.
providers
p
.
channel
.
notify
method
:
'set
Active
Highlights'
method
:
'set
Focused
Highlights'
params
:
highlights
$scope
.
scrollTo
=
(
annotation
)
->
...
...
h/static/scripts/guest.coffee
View file @
e4be6357
...
...
@@ -143,7 +143,7 @@ class Annotator.Guest extends Annotator
if
value
then
@
plugins
.
Heatmap
.
_update
()
)
.
bind
(
'set
Active
Highlights'
,
(
ctx
,
tags
=
[])
=>
.
bind
(
'set
Focused
Highlights'
,
(
ctx
,
tags
=
[])
=>
for
hl
in
@
getHighlights
()
if
hl
.
annotation
.
$
$tag
in
tags
hl
.
setActive
true
,
true
...
...
h/templates/client/viewer.html
View file @
e4be6357
...
...
@@ -38,9 +38,9 @@
thread=
"child"
thread-filter
thread-collapsed=
"!search.query"
ng-include=
"'thread.html'"
ng-mouseenter=
"
activate
(child.message)"
ng-mouseenter=
"
focus
(child.message)"
ng-click=
"scrollTo(child.message)"
"
ng-mouseleave=
"
activate
()"
ng-mouseleave=
"
focus
()"
ng-repeat=
"child in vm.container.children | orderBy : sort.predicate"
ng-show=
"vm.container && shouldShowThread(child) &&
(count('edit') || count('match') || !threadFilter.active())"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment