1. 08 Feb, 2017 5 commits
    • Robert Knight's avatar
      Merge pull request #216 from hypothesis/dont-delete-cached-oauth-access-token · 0e8e035f
      Robert Knight authored
      Don't delete cached OAuth access token
      0e8e035f
    • Sean Roberts's avatar
      Merge pull request #212 from hypothesis/update-docs · 480e1bae
      Sean Roberts authored
      Add examples in docs for sidebar trigger and annotation count display.
      480e1bae
    • Sheetal Umesh Kumar's avatar
    • Sean Hammond's avatar
      Don't call clearCache() when using OAuth · dbf5d781
      Sean Hammond authored
      When using OAuth (the host page provides an embedded grant token) don't
      call auth.clearCache() on session update. The authorized user never
      changes when using OAuth with a grant token embedded in the page, and
      the oauth-auth service's clearCache() is a no-op anyway, so there is no
      point in calling clearCache() here.
      dbf5d781
    • Sean Hammond's avatar
      Don't delete the cached OAuth access token · 0e229735
      Sean Hammond authored
      This fixes an issue that, when the client is embedded on a partner site
      using third-party auth:
      
      1. The client reads grant token that the client embeds in their page
         from the page
      2. The oauth-auth service sends a grant token request, receives back an
         access token which it caches
      3. session.js calls oauth-auth's clearCache(), which deletes the access
         token
      4. The next time the access token is needed the oauth-auth sends a
         second grant token request, with the same grant token, and gets a
         second access token
      
      So two grant token requests are sent, when only one was needed, because
      the cached access token is deleted unnecessarily.
      
      The fix is to make clearCache() in oauth-auth a no-op for now. For now
      it never makes sense for oauth-auth to clear its cached access token.
      OAuth is currently only used when the client is embedded in partner
      sites and the grant token is embedded in the page by the client. Since
      the grant token never changes, there's never any reason to clear the
      access token and request a new one using the same grant token again (you
      would just be requesting a new access token for the same user account).
      0e229735
  2. 06 Feb, 2017 2 commits
  3. 03 Feb, 2017 9 commits
  4. 02 Feb, 2017 6 commits
  5. 01 Feb, 2017 8 commits
  6. 30 Jan, 2017 5 commits
  7. 27 Jan, 2017 2 commits
  8. 26 Jan, 2017 3 commits