Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 24 Jun, 2020 2 commits
  3. 19 Jun, 2020 5 commits
    • Robert Knight's avatar
      Update test following previous commit · ba433e28
      Robert Knight authored
      ba433e28
    • Robert Knight's avatar
      Enable strict null checks · dada123b
      Robert Knight authored 
      In my experience this surfaces a lot of real potential issues and is
harder to turn on later.

Also set the `target` field, as otherwise TS assumes that we're going to
compile down to ES3 (!).
      dada123b
    • Robert Knight's avatar
      Make the `lint` run type-checking · 3f109416
      Robert Knight authored
      3f109416
    • Robert Knight's avatar
      Augment and fix JSDoc so that src/sidebar/util typechecks · 1ec861b7
      Robert Knight authored 
      In addition to `src/sidebar/util`, it was also necessary to update types in
`src/sidebar/host-config.js` and `src/sidebar/build-thread.js` as these
are used from `src/sidebar/util`.

In the process I also found a case where the `call` function in
`postmessage-json-rpc.js` was being called with the wrong arguments in
some cases. The `timeout` parameter was passed in place of the `params`
argument.

 - Add stubs type definitions for objects returned from the Hypothesis
   API in `src/types/api.js`

 - Add and fix sufficient JSDoc type declarations that all JS files in
   src/sidebar/util typecheck.

 - Explicitly ignore a small number of expressions that TypeScript
   cannot typecheck using `// @ts-ignore`

 - Change several expressions from `expr` to `/** @type {Type} */
   (expr)` to narrow types down in cases where TS can't automatically
   infer the type.
      1ec861b7
    • Robert Knight's avatar
      Add a command to run TypeScript to typecheck JSDoc · 9e5697b3
      Robert Knight authored
      9e5697b3
  5. 15 Jun, 2020 2 commits
  7. 12 Jun, 2020 1 commit
  9. 11 Jun, 2020 1 commit
  11. 10 Jun, 2020 1 commit
  13. 09 Jun, 2020 6 commits
  15. 08 Jun, 2020 6 commits
  17. 03 Jun, 2020 1 commit
    • Kyle Keating's avatar
      Prevent scrolling to annotations from links or buttons · 49c47008
      Kyle Keating authored 
      If an event is triggered from a link or button or a descendent of a link or button, then prevent scrollToAnnotation from firing. It is assumed in these cases that a more specific action was intended and the page shall not scroll to the underlying annotation. Additional, dom-element.js has moved to /shared since its now used in both the annotator and sidebar
      49c47008
  19. 02 Jun, 2020 8 commits
  21. 01 Jun, 2020 7 commits