- 02 Jul, 2020 1 commit
-
-
Robert Knight authored
- Add JSDoc for the `actionTypes` function. This uses an advanced TS feature called "mapped types" [1] to specify that the result is an object with the same keys as the input object, but where the values are strings rather than functions. Going forwards there are likely better ways to replace `actionTypes`. The original purpose was to make sure that the `type` field of each action object matches up with a key of the `updates` object. - Fix various existing JSDoc errors - Add imports for the existing `Group` and `Annotation` references - Add missing `group` property to `Annotation` type [1] https://www.typescriptlang.org/docs/handbook/advanced-types.html#mapped-types (See in particular the `in keyof T` mentions).
-
- 01 Jul, 2020 5 commits
-
-
Robert Knight authored
Typecheck SvgIcon
-
Robert Knight authored
- Remove a param comment that duplicates information in the type definition - Add a note about a defensive null-check
-
Lyza Gardner authored
Adjust the scale of layout spacing
-
Lyza Gardner authored
Refactor annotation publish control styling
-
Robert Knight authored
Typecheck `shared/components/svg-icon.js`. This enables edit-time rather than runtime detection of incorrect usage, as well as enabling UI component props to reference types (eg. API objects) defined elsewhere with JSDoc. Props are currently declared with both JSDoc and via `SvgIcon.propTypes`. The intent is that the JSDoc is the canonical definition, but `SvgIcon.propTypes` is still useful to catch incorrect usage from other parts of the code which are currently not typechecked.
-
- 30 Jun, 2020 3 commits
-
-
Robert Knight authored
Typecheck src/sidebar/services
-
Robert Knight authored
As suggested in PR feedback, this can help readability. We should do the same in parameter lists as well.
-
Robert Knight authored
Bump through2 from 3.0.1 to 4.0.1
-
- 29 Jun, 2020 8 commits
-
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.702.0 to 2.706.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.702.0...v2.706.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v4.0.0...v4.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.10.2 to 9.10.3. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.10.2...v9.10.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.17.0 to 5.18.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.17.0...5.18.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.8.2 to 9.8.4. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/9.8.2...9.8.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.20.0 to 7.20.1. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.20.0...v7.20.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.11 to 2.0.12. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.0.11...2.0.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [through2](https://github.com/rvagg/through2) from 3.0.1 to 4.0.1. - [Release notes](https://github.com/rvagg/through2/releases) - [Commits](https://github.com/rvagg/through2/compare/v3.0.1...v4.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 26 Jun, 2020 13 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Change `margin` SASS var names for clarity
-
Lyza Gardner authored
Refactor styling of VersionInfo and related HelpPanel components
-
Lyza Danger Gardner authored
Refactor VersionInfo's styling to be a narrow-first responsive layout so that it is readable when the sidebar is narrow.
-
Robert Knight authored
Enable minimal typechecking for src/sidebar/services. Note that most service factories are missing parameter documentation, so their usage is not checked. - Fix up JSDoc errors and omissions in `src/sidebar/services` - Add types for the `tiny-emitter` npm module. The module does ship with its own types, but doesn't specify the types for the default export - Add additional properties to `Annotation`, `Group` and `Profile` API objects
-
Robert Knight authored
Typecheck `src/annotator/{config, util}` and `src/sidebar/*.js`
-
Robert Knight authored
Simplify `since:<time>` filter query parsing and remove `result:<term>` parsing
-
Robert Knight authored
Enable typechecking for the following directories: - src/annotator/config - src/annotator/util - src/sidebar (excluding `ga.js`, `icons.js` and `index.js`) Many functions in these directories are still not annotated, but this will be added over time. `ga.js` was excluded because it deals with globals added by Google Analytics. `icons.js` was excluded because TS doesn't know how to handle `require('.../some-icon.svg')`. `index.js` was excluded because that imports (and thus triggers checking for) every other file in the sidebar app. It will need to be enabled last.
-
Robert Knight authored
There were no tests for this and this field is not used in the code that consumes the output of filter query parsing (`view-filter.js` and `stream-filter.js`).
-
- 25 Jun, 2020 10 commits
-
-
Kyle Keating authored
Don’t hide the component when `store.isLoading()` is true. This only causes a re-render of that component and momentarily removes it from the DOM. Its not actually invalid to show the filter buttons while loading because the filter is still being applied.
-
Lyza Danger Gardner authored
As these variables are used for more things than just margins, a more neutral name is clearer.
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Extract styles from Annotation Body, License and Quote
-
Lyza Gardner authored
Add utility classes for one-liners
-
Robert Knight authored
Upgrade to ESLint v7.x
-
Robert Knight authored
Update eslint-config-hypothesis which was in turn holding back various other ESLint packages. The newest update to eslint-plugin-react-hooks found an incorrect usage of `useCallback` in `ThreadCard` where `debounce` was being called on ever render instead of only when certain dependencies changed.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-