- 26 Feb, 2020 1 commit
-
-
Lyza Danger Gardner authored
Add a new `autosaveService`, which subscribes to the store and automatically saves new highlights. Remove implementation of highlight auto-save from `Annotation` controller.
-
- 25 Feb, 2020 2 commits
-
-
Robert Knight authored
Fix manifest not rebuilding after source file changes
-
Robert Knight authored
Fix an issue where `build/boot.js` and `build/manifest.json` were not rebuilt after script/style bundles were updated or other resources were updated in the `build/` directory. The `updateManifest` gulp task function was not returning a value so gulp silently treated the task as never completing. I thought this generated a warning at some point in the past, but it looks like that was not happening. This fixes an issue in development where `build/boot.js` would sometimes be generated before `build/scripts/boot.bundle.js` had been fully written and then not regenerated after that file was written. This resulted in an empty or incomplete `build/boot.js` file and as a result the dev client would fail to start.
-
- 24 Feb, 2020 9 commits
-
-
Robert Knight authored
Bump sinon from 8.1.1 to 9.0.0
-
dependabot-preview[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 8.1.1 to 9.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinonjs/sinon/compare/v8.1.1...v9.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump @sentry/browser from 5.12.1 to 5.12.4
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.12.1 to 5.12.4. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.12.1...5.12.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.43.1 to 17.0.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.43.1...v17.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.620.0 to 2.624.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.620.0...v2.624.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Lyza Gardner authored
Make `NewNoteBtn` show login prompt if user not logged in
-
Lyza Danger Gardner authored
Apply the same UX to `NewNoteBtn` as to the annotator for attempting to create new annotations when not logged in. Display login prompt. Also refactor to remove dependency on `$rootScope` and events
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 1.7.0 to 2.4.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 21 Feb, 2020 8 commits
-
-
Lyza Gardner authored
Fix error in angular callback by providing `event` object
-
Lyza Danger Gardner authored
Fix error from expected event object in angular
-
Lyza Gardner authored
Move rendering of sidebar errors above tabs for consistency.
-
Lyza Gardner authored
Apply login-prompt UX to reply action if user not logged in
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
This has no real effect as the tabs are not rendered when sidebar errors are rendered, but for consistency, let’s put all sidebar-ish errors above the tabs.
-
Lyza Gardner authored
Disable unauthenticated annotating and highlighting
-
Lyza Danger Gardner authored
-
- 20 Feb, 2020 8 commits
-
-
Lyza Gardner authored
Address remaining contrast nits
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
We’ve decided not to remedy this for now, as the `disabled` state and other attributes of the publish button suffice, but in the future it would be good to find a better contrast solution here.
-
Lyza Gardner authored
Increase contrast in annotation cards to meet WCAG AA requirements
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Increase contrast of Button components (a11y)
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.619.0 to 2.620.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.619.0...v2.620.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 19 Feb, 2020 10 commits
-
-
Lyza Danger Gardner authored
-
Robert Knight authored
Assume white background by default in a11y tests
-
Robert Knight authored
Add `lang=""` to user-generated/chosen content in sidebar UI
-
Robert Knight authored
Do not set "aria-pressed" attribute for non-toggle buttons
-
Robert Knight authored
Several accessibility tests were failing incorrectly because axe-core compared the component's foreground text color against the #ececec color used for the body of the sidebar app, whereas the components are in fact rendered on a white background. Change a11y tests to assume a white background by default, as that is the case for _most_ elements in the UI. Individual a11y tests can customize this as appropriate.
-
Robert Knight authored
Tag suggestions are user-supplied content, so indicate that language is unknown/may differ from the UI.
-
Robert Knight authored
Setting the `aria-pressed` attribute on a button indicates to assistive technology that it is a toggle button. Because the `Button` component always set this attribute and the `isActive` prop had a default value of false, this meant that every `Button` in the UI was identified as a toggle button by screen readers. Fix the issue by renaming `isActive` to `isPressed` and aligning it with the behavior of `aria-pressed`: - If `true`, the button is a pressed toggle button - If `false`, the button is a non-pressed toggle button - If undefined, the button is a regular button and `aria-pressed` is not set
-
Robert Knight authored
Add accessible label to annotation body markdown editor
-
Robert Knight authored
Extract repeated references to editor text string into a variable to make it more obvious how different statements in the test are connected.
-
Robert Knight authored
Add accessible label to search input field
-
- 18 Feb, 2020 2 commits
-
-
Robert Knight authored
Bump postcss from 7.0.26 to 7.0.27
-
dependabot-preview[bot] authored
Bumps [babel-plugin-mockable-imports](https://github.com/robertknight/babel-plugin-mockable-imports) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/robertknight/babel-plugin-mockable-imports/releases) - [Changelog](https://github.com/robertknight/babel-plugin-mockable-imports/blob/master/CHANGELOG.md) - [Commits](https://github.com/robertknight/babel-plugin-mockable-imports/compare/v1.7.0...v1.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-