- 05 Feb, 2021 2 commits
-
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
- 03 Feb, 2021 6 commits
-
-
Robert Knight authored
All npm packages should have a license, and yarn complains if there isn't one. The license chosen here is the same as in the client's package.json.
-
Robert Knight authored
Generate TypeScript definition files as part of the frontend-shared package so that TS can typecheck code that uses the package in other projects. Within the client repository we don't need to generate these files because TypeScript will read the JSDoc comments. When the package is consumed from other projects however, it seems that it does not read the JSDoc comments. Note that when these `.d.ts` files exist, they are used in preference to JSDoc comments by other code in the client repository. Therefore they need to be kept up to date when the files are recompiled in watch mode. In the process of adding this I discovered an issue that the method of running CLI commands in gulp tasks in `scripts/gulp/frontend-shared.js` did not fail if the exit status was non-zero. I created a `run` utility that handles this correctly along with providing the desired defaults.
-
Robert Knight authored
-
Robert Knight authored
Change the glob to allow for `test/` dirs inside subdirectories of `frontend-shared/src`.
-
Robert Knight authored
This directory contains the compiled version of code from `frontend-shared/src`. Only the source should be instrumented.
-
Robert Knight authored
`useElementShouldClose` is a useful generic hook for implementing non-modal dialogs. We also use it in the LMS frontend, so it makes sense to share the implementation. This function depends on `normalizeKeyName`, so I moved that as well. `useElementShouldClose` also depended on a `listen` helper. This helper is not currently used by any other code so I moved it into `use-element-should-close.js` as a non-exported helper function and simplified it. In the process I found it was necessary to change the gulp task that builds the frontend-shared/lib/ directory to handle subdirectories under frontend-shared/src/.
-
- 02 Feb, 2021 5 commits
-
-
Robert Knight authored
The previous description was largely about how `useElementShouldClose` was implemented rather than about how it was intended to be used. Rewrite it to explain the what/when rather than how and use fewer words.
-
Robert Knight authored
`useElementShouldClose` allowed passing a ref to a Preact component rather than a ref to a DOM element. Support for this relied on Preact component's having a `base` property, which is going away in future [1] All of the actual usage of `useElementShouldClose` in the app passed an Element ref, so I've simply removed the functionality and associated tests. [1] https://github.com/preactjs/preact/pull/2971
-
Lyza Danger Gardner authored
Refactor the way headless threads are handled regarding visibility and reply toggling. Add an `AnnotationMissing` component; harmonize props between `Annotation` and `AnnotationMissing`. Add a new `AnnotationReplyToggle` component.
-
Lyza Danger Gardner authored
Change `forcedVisibleAnnotations` => `forcedVisibleThreads` and use thread ids instead of annotation $tags. This allows the forcing-visible of threads that lack an annotation and is more appropriate overall: threads are forced-visible, not annotations.
-
Lyza Danger Gardner authored
-
- 01 Feb, 2021 12 commits
-
-
Kyle Keating authored
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.30.0 to 6.0.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.30.0...6.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.3 to 10.2.4. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/10.2.3...10.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.0.1 to 6.0.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.0.1...v6.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.5.11 to 10.5.12. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.5.11...10.5.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.19.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.18.0...v7.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.831.0 to 2.834.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.831.0...v2.834.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.0.14 to 18.0.15. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.0.14...v18.0.15) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Lyza Danger Gardner authored
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.30.0 to 6.0.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.30.0...6.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [commander](https://github.com/tj/commander.js) from 6.2.1 to 7.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/tj/commander.js/compare/v6.2.1...v7.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 29 Jan, 2021 2 commits
-
-
Kyle Keating authored
Action will perform the following: - Test if any changes to the frontend-shared/ folder have been made since the last release of the client (parent). - If they have, then it will get the last published version of the frontend-shared package, add 1 to the number, and save new version to package.json file - Build the frontend-shared for release - Publish the frontend-shared package to npm Additionally add lint support to .github/
-
Kyle Keating authored
-
- 26 Jan, 2021 11 commits
-
-
Kyle Keating authored
-
Kyle Keating authored
- Add babel presets for frontend-shared to transpile js/jsx - Add `build` script to transpile frontend-shared and output sourcemaps and transpiled js code to /lib - Add frontend-shared /src/index.js as a way to serve as a root import location for the frontend-shared lib - Fix up frontend-shared/package.json so publishing will work as expecting and include only intended files - Add a browserify config in the frontend-shared package.json file so that driving client will be able to bundle it and still import svg and html files that are nested inside /frontend-shared/src - Add svg-icon to serve as the first shared js component - Move several .svg files into the lib that are relaxant for testing svg-icon that also seem share-worthy - Make modifications to ensure that typechecking, linting, and testing all work as expected and ignore /lib folder - Change karma config so that tests will automatically run on /frontend-shared, driven from the client's gulp command - Added new gulp tasks to help with building and linking the frontend-shared package so that is it fully transparent with existing tooling - Add gulp-babel and gulp-sourcemaps packages to help with build tasks for /frontend-shared that are necessary for symlinking / building the package - Used new SvgIcon sidebar/index.js as a tester. This requires making two copies of registerIcons while we make the transition. Replacing all call sites of SvgIcon would be too large for an already overwhelming commit
-
Kyle Keating authored
- Add basic bare bones frontend-shared package as a sub-package, not a workspace since they can not be "public" - Move the mixin/focus.scss file into this package - Update scss @use dependencies to reference the new package (this will point to node_module/@hypothesis/frontend-shared/... location)
-
Eduardo Sanz García authored
This page will allow us to investigate if it is possible to capture the selection event from outside the shadow DOM, and if so, how can we do it.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Also: update tests for modern syntax
-
Robert Knight authored
The real function returns a function. The mock returned a number. This happened not to cause a failure currently but it could break with future changes in Preact.
-
Robert Knight authored
`assert.isEmpty()` checks the size of an array, map or set or counts the number of keys on an object. It doesn't know how to check that an Enzyme wrapper produced no output. `assert.isEmpty(wrapper)` passes due to implementation details of the Enzyme wrapper - it behaves like an object with no properties. However it _always_ passes regardless of the number of nodes in the wrapper, which is not the intended behavior here.
-
Robert Knight authored
String styles are a Preact-specific feature which is likely to go away in future. Pass an object instead.
-
- 25 Jan, 2021 2 commits
-
-
Eduardo Sanz García authored
Because the code in `dev-server/static/scripts/util.js` is not transpiled by Babel, it needs to be compatible with all the browsers versions in `browserslist` (`package.json`). Optional chaining `(?.)` is for example not support in Chrome versions < 80. This is only an issue when testing `localhost:3000` on these supported, but older browser versions.
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.1 to 10.2.3. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/10.2.1...10.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-