1. 10 Nov, 2022 7 commits
  2. 08 Nov, 2022 5 commits
  3. 07 Nov, 2022 13 commits
  4. 04 Nov, 2022 9 commits
  5. 03 Nov, 2022 2 commits
  6. 02 Nov, 2022 4 commits
    • Lyza Danger Gardner's avatar
      Update highlights CSS to prepare for clustered-highlight styling · 0cf562a1
      Lyza Danger Gardner authored
      Refactor `highlights.scss` to configure highlight style and subsequently apply styles. Add CSS variables for use for dynamic styling of highlight clusters.
      
      Update some comment wording in `gulpfile` for clarity.
      0cf562a1
    • Robert Knight's avatar
      Add a couple of notes in comments · f8f24706
      Robert Knight authored
      These address a couple of issues raised in code review.
      f8f24706
    • Robert Knight's avatar
      Compare annotation locations by CFI and text position · 1f6ea342
      Robert Knight authored
      For annotations on EPUBs, text position selectors can only be validly compared
      when they come from annotations made on the same EPUB Content Document. For
      annotations that come from different content documents, it is necessary to first
      compare the ordering of the content documents using CFIs, and then compare text
      positions.
      
      The use of `Number.POSITIVE_INFINITY` with replaced with
      `Number.MAX_SAFE_INTEGER` when handling annotations without positions, as
      `Math.sign(MAX_SAFE_INTEGER - MAX_SAFE_INTEGER)` is 0 (ie. treat two annotations
      with missing positions as having the same position), but
      `Math.sign(POSITIVE_INFINITY - POSITIVE_INFINITY)` is NaN.
      1f6ea342
    • Robert Knight's avatar
      Add additional tests and clarify string vs number step comparisons · 0b272c0b
      Robert Knight authored
      CFI steps that cannot be parsed as base-10 integers are invalid, but we try to
      fail gracefully in `compareCFIs` by using a string comparison.  This introduces
      a problem when one step is an integer and another is a string. Handle this by
      arbitrarily deciding that numbers sort before strings. We could have chosen
      other approaches as well.
      0b272c0b