Checking `typeof <var>` is only needed when the variable may not exist
(eg. some browser global).

Put the logic for getting the grant token in one place so it can be
better documented.

Also remove or simplify some other code slightly upon a second reading.

A call to `refreshAccessToken` is not the only way that the token can
change while waiting for a response to the `POST /api/token` endpoint.

The previous name was a vestige from the days of Angular 1.x in the
client. Use a clearer name instead.

Refactor and better document the `tokenGetter` method to make it easier
to follow:

 - Split some sub-steps out into helper methods
 - Add comments to call out the high-levels steps in the flow

Extract a helper from a long async method to shorten it.

Make several functions/methods in the service easier to follow by
refactoring promise chains to async/await.

 - Add tests for `scrollToAnnotation`

 - Add test for failed `getDocumentInfo` request to host page

Convert the `frameSync` service to an ES class and rewrite the
documentation that explains what the service does.

Some internal `frameSync` methods are still set up in the constructor
with closures. These can be converted to ES class methods in later
refactoring.

Part of https://github.com/hypothesis/client/issues/3298.

Chrome 89 printed the following warnings on the console:

```
shadow-root.js:67 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive
```

See also: https://www.chromestatus.com/feature/5745543795965952

I have removed a listener that it isn't no longer needed, because it is wrapped in
a shadow DOM that already stop the bubbling up of the event.

Another 'touchstart' listener had the potential to slow down scrolling
on the host page on mobile devices. To avoid that we have made listener
passive.

These changes remove the warnings without affecting the current
behaviour of the application.

Move the logic for retrying API metadata fetching into the `getJSON`
helper function so that it is used both when fetching the API index
(`/api`) and the service links (`/api/links`).

Rename property from `params` to `unusedParams` for clarity.

Change the way that links pointing into the Hypothesis service (eg. for
tags, users, account settings etc.) are fetched and generated. The new
implementation better matches patterns used elsewhere in the application
and ensures that UI components displaying these links re-render if the
`/api/links` response is received after the component is initially
rendered.

 - Move the logic for rendering the URL templates from the `serviceUrl`
   service into a selector in the `links` store module. Components then
   render links using `store.getLink(...)`. This ensures use of the existing
   mechanism that re-renders components when relevant store data changes.

 - Convert the `serviceUrl` service to an ES class

 - Move the logic for fetching URL templates from the `/api/links`
   endpoint into an `init` method of the `ServiceURLService` service.
   This matches the convention used by several other services.

 - Remove unused `serviceUrl` dependency from `groups` service

As noted in a comment, the check is mainly intended to prevent infinite
loops in tests.

The name options implies a misc bag of optional properties, whereas this
is a mandatory set of callbacks.

This found a mistake in the types of several references to the document
URI, which is not always present.

This found an error in some of the existing types in the `api` service.

Refactor this class to new conventions as part of
https://github.com/hypothesis/client/issues/3298.

 - Convert the `auth` service to an ES class
 - Replace the internal `emitter` variable with inheritance
 - Rename the module from `oauth-auth.js` to just `auth.js`. The
   previous name is a vestige from when authorization was migrated from
   cookie-based to OAuth-based

 - Convert `features` service to a class

 - Remove the unused `flagEnabled` method. Calls to this method have
   gradually been replaced by `store.isFeatureEnabled`.

 - Move the initialization of the background sidebar => annotator
   synchronization of feature flag information into an `init` method
   which is then called from the sidebar's entry point. This pattern is
   consistent with several other services. It is also necessary for services
   that are not depended upon by anything else because services are
   lazily instantiated.

Put all the initialization logic in one place instead of spreading it
between the constructor and `init` method.

Part of https://github.com/hypothesis/client/issues/3298

Part of https://github.com/hypothesis/client/issues/3298

This conversion revealed some incorrect and inconsistent types.

- The `filter` method was documented to return `Tag`s but actually
  returned strings
- The `store` method required a list of `Tag`s but only used the `text`
  property from it. This method has been simplified to just accept a
  list of tag strings instead.

Part of https://github.com/hypothesis/client/issues/3298

Part of https://github.com/hypothesis/client/issues/3298

In the process an issue was uncovered where an annotation could
incorrectly be created without a group if there was no focused group.
Address the issue by throwing an error in `AnnotationsService#create` if
there is no focused group. Handling the situation in a
context-appropriate way is left an exercise for higher-level code.

Part of https://github.com/hypothesis/client/issues/3298

Convert `localStorage` class to an ES class and add types to various
places where it is referenced.

Part of https://github.com/hypothesis/client/issues/3298.

Instead, use SASS from `frontend-shared` package

These shared button components have been moved to the `frontend-shared`
package.

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.884.0 to 2.888.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js/compare/v2.884.0...v2.888.0)
Signed-off-by: dependabot[bot] <support@github.com>

Bumps [sass](https://github.com/sass/dart-sass) from 1.32.8 to 1.32.10.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.32.8...1.32.10)
Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)
Signed-off-by: dependabot[bot] <support@github.com>

Update `StreamFilter` class to current service conventions. Part of
https://github.com/hypothesis/client/issues/3298.

Mock `retryPromiseOperation` in APIRoutesService tests to speed up tests
where the operation is retried multiple times.

The customized result for the first stub call was not used because a
more specific response was defined earlier using `withArgs`.

Follow the pattern introduced in https://github.com/hypothesis/client/pull/3296
to convert the API routes service to a class and improve various types
along the way.