- 08 Apr, 2015 1 commit
-
-
Randall Leeds authored
A `$rootScope.$apply` is removed from the `on` method of the iframe- side cross-frame code. This code was incorrect because the registration of a handler does not require a digest cycle. This was seemingly innocuous before, but adding the analytics module changed the order of injection resolution such that it caused a problem wherein a digest cycle happens before angular has even finished compiling the DOM and processing ng-template scripts. The result was that route templates were not being read from the template cache and 404s resulted on stream navigation and auth pages.
-
- 03 Apr, 2015 3 commits
-
-
Randall Leeds authored
Revert "Merge pull request #2086 from hypothesis/2052-scroll-to-sign-in-form-on-clicking-sign-in-link" This reverts commit ca535b6d8a81af343489120e02326c34f71a3d46, reversing changes made to 0988bffc2d8c968ff35bea177ac65868796b8563.
-
Nick Stenning authored
CLI utility to send invitations
-
Nick Stenning authored
Test form-input interaction with form-validate
-
- 02 Apr, 2015 18 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
Since changing the size of button icons in de75319 we can now style these actions with button markup and the btn-clean class. The last remnants of .magicontrol go away.
-
Randall Leeds authored
This reverts commit 08d991f066e48c0388ff76ce24a611c1f553a096, reversing changes made to d488f9c491c0334ee4f46210ba17127df169a9e6.
-
Randall Leeds authored
Mock and test that half of the interaction, and in doing so show that it's also optional to use the validator with the input.
-
Randall Leeds authored
Scroll to new annotations on creation
-
Nick Stenning authored
Use domain as citation title if no document
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Randall Leeds authored
Partly a reaction to fce1f2c, which made icons overall smaller.
-
Randall Leeds authored
This is a bad way to address places where what we really want is the icon as a badge on an element that has text next it. We have special styles for buttons, but not for other scenarios. Icons should be resized based on semantic styles for their use rather than globally.
-
Randall Leeds authored
The config blocks should be after the declarations of services, at least, so that they can decorate services.
-
Randall Leeds authored
-
- 01 Apr, 2015 3 commits
-
-
Sean Hammond authored
If necessary scroll the sidebar to show a newly created annotation (when the user clicks the new annotation button). Add unique ids to the <li> elements that contain the annotations, then on creating a new annotation set the URL fragment to #<id> and scroll to show the element. Fixes #2053.
-
gergely-ujvari authored
Bump the number of annotations loaded per request to 200
-
Nick Stenning authored
The overhead associated with a single search call is high enough that loading only 20 annotations at once is too little. In a naive test this reduces the time take to request about 300 annotations from 5 seconds to about 800ms (which, IMO, is still far too slow.)
-
- 31 Mar, 2015 2 commits
-
-
Sean Hammond authored
An annotation's document.title is used as the citation when displaying an annotation. If this is an older annotation that has no document, fall back to using the domain as the citation title instead. Fixes #1542
-
Randall Leeds authored
Remove Dockerfile entrypoint
-
- 30 Mar, 2015 5 commits
-
-
Randall Leeds authored
Handle internal server errors in the registration form
-
Sean Hammond authored
Add a test for how the frontend handles an invalid response from the server when trying to register a user account. This happens if the server has an uncaught exception.
-
Sean Hammond authored
Merge branch '1755-handle-internal-server-error-in-registration-form' of github.com:hypothesis/h into 1755-handle-internal-server-error-in-registration-form Conflicts: h/static/scripts/account/auth-controller.coffee
-
Sean Hammond authored
Add a frontend test for when the server returns an error response with a "reason" but no "errors" in the JSON-object response body.
-
Sean Hammond authored
When catching a non-JSON error response from the server, when trying to register a user.
-
- 27 Mar, 2015 8 commits
-
-
Randall Leeds authored
Hide orphan annotations in the sidebar
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
csillag authored
-
Sean Hammond authored
This fixes #1755: no error is shown on the client side when an attempt to register an account receives a 500 Server Error response. The failure() method in AuthController gets called and tries to do {errors, reason} = response.data, but this raises a TypeError because response.data is undefined (because the response didn't have a valid JSON body), so the client crashes as well. The fix is to catch this exception on the client side, and show a generic error to the user.
-
Nick Stenning authored
Improve packaging, bundling and module boilerplate
-