Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 12 Jul, 2021 1 commit
    • Kyle Keating's avatar
      Remove aria-label from TagEditor and AnnotationPublishControl button · 4ae836c4
      Kyle Keating authored 
      Per WCAG 2.1 criterion: 2.5.3 Label in Name--we should not differentiate between the aria-label and the visual name in an input element. In the case of the TagEditor, the `placeholder` and `aria-label` were different. The simple fix is to remove `aria-label`.

The second problem is with AnnotationPublishControl's button where the `aria-label` and button's text did not match. Again, the simple fix is to remove `aria-label`.
      4ae836c4
  3. 09 Jul, 2021 2 commits
    • Robert Knight's avatar
      Always use object shorthand for properties · 2cccebc2
      Robert Knight authored 
      Enforce the use of object shorthand syntax everywhere for consistency.
eg. `{ foo }` instead of `{ foo: foo }`. We had already converted most
occurrences manually.
      2cccebc2
    • Robert Knight's avatar
      Convert remaining anonymous callbacks to arrow functions · 088864e9
      Robert Knight authored 
      We've been gradually converting anonymous functions to arrow functions
since adopting ES6. This commit uses ESLint to finish the process by
converting the remaining non-named, non-`this`-using callbacks to arrow
functions.

 - Enable `prefer-arrow-callbacks` lint rule. The `allowNamedFunctions`
   option is enabled because we have a few instances (eg. in
   gulpfile.js) of explicitly naming functions for use in debugging /
   logging etc.

 - Run `eslint --fix .` and `yarn format` to automatically fix up the
   code
      088864e9
  5. 07 Jul, 2021 1 commit
  7. 06 Jul, 2021 12 commits
  9. 05 Jul, 2021 1 commit
  11. 02 Jul, 2021 2 commits
    • Eduardo Sanz García's avatar
      Render the `NotebookModal` only when `groupId` is defined · fcf1e6ac
      Eduardo Sanz García authored 
      On Firefox, I have noticed that the notebook close button is briefly
displayed and then hidden. This delay is probably caused by time that it
takes to parse the CSS until it is applied. To avoid this 'blink' we
render the component only when the `groupId` is set.
      fcf1e6ac
    • Eduardo Sanz García's avatar
      Small visual improvements for the notebook close button · 1d0e3a32
      Eduardo Sanz García authored 
      Currently, because of the `notebook` and `sidebar` are not able to
communicate directly it is not possible to place the close button on the
`notebook` app itself.

While waiting for the above to be fixed, I propose a few minor style
changes:

* Changed the `LabeledButton` to `IconButton` and only show the `X`
  (cancel icon). This is a widely understood and accepted pattern for
  modals

* Increase the size of the cancel icon

* Re-enable the cursor when hovering on the button (it seems that the
  `cursor: pointer` rule was not longer functional)

* Made the margin bigger to avoid the browser scrolling bar to hidden by
  the button.

These changes are meant to be a temporary improvement.
      1d0e3a32
  13. 29 Jun, 2021 3 commits
  15. 28 Jun, 2021 8 commits
  17. 24 Jun, 2021 4 commits
  19. 23 Jun, 2021 3 commits
    • Kyle Keating's avatar
      Remove options.defaultValue from hostPageSetting · 0de918ff
      Kyle Keating authored 
      - defaultValue is now handled inside of getConfig so this code is unused.

- hostPageSetting now returns undefined, rather than null, if a value is not found in the config. The undefined value will trigger the defaultValue to take effect in getConfig if a defaultValue is provided.
      0de918ff
    • Kyle Keating's avatar
      Fix default value for showHighlights · da3a3466
      Kyle Keating authored 
      The default was incorrectly set to null because the previous code was setting it to null, however that null value was used to then set it a second time to "always" Part of this refactor is making the code more clear so this logic is explicit. The defaultValue for showHighlight is in fact 'always'
      da3a3466
    • Kyle Keating's avatar
      Remove isBrowserExtension logic from settings.js · 3a9d395a
      Kyle Keating authored 
      nb. This is now handled inside of getConfig()
      3a9d395a
  21. 22 Jun, 2021 2 commits
    • Kyle Keating's avatar
      Pass config name directly to getValue · b208c1e9
      Kyle Keating authored 
      This change fixes the usage of redundant names being expressed in the configDefinitions map.
      b208c1e9
    • Kyle Keating's avatar
      Add `allowInBrowserExt` and `defaultValue` to configDefinitions · d834fefd
      Kyle Keating authored 
      - Logic for `allowInBrowserExt` and `defaultValue` are moved up into getConfig() from various places inside settings. There are no external changes here, but there are a few subtle changes to how a config values work.

  1. Previously if in a browser ext context and  `allowInBrowserEx` was false (default), then the value was was changed to null. This bit of logic was not entirely explicit, but now the logic is that the value will be set to the `defaultValue` if provided or otherwise the value will be omitted entirely. Currently, all values have a `defaultValue` and most of the defaults are null. This ensures things work the same, but also helps bring clarity to what values will be transformed under this condition. Later we can revisit these config values and determine if any don't need a default or simply leave them as is.

  2. The `defaultValue` was previously only used for several fields, but now its set for every field for clarity. It should also be noted that the `defaultValue` will now take precedent over the `coerce` method if settings returns an undefined value for that config key. This is in contrast to how it worked before, but was problematic under some possible circumstances. For example, if a settings value was not found or undefined, and a `defaultValue` was true and the coerce was `toBoolean`, then the value would become false rather than true and that is confusing because the default would not work due to the `coerce` taking precedent. This is now fixed.

- Remove default export from is-browser-extension
      d834fefd
  23. 21 Jun, 2021 1 commit