- 11 Feb, 2021 2 commits
-
-
Kyle Keating authored
- Remove existing customized styling on text and input fields - Override default outline style and instead, replace with a box-shadow that is styled similar to the default outline but with a fixed color - This allows the outline to still retain a small border radius, and a custom color at the same time
-
Eduardo Sanz García authored
Remove a few container elements left-over from the tests.
-
- 10 Feb, 2021 1 commit
-
-
Kyle Keating authored
Change -B to --open-browser
-
- 08 Feb, 2021 11 commits
-
-
dependabot-preview[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.5 to 1.32.6. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.32.5...1.32.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.0.3 to 6.1.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.0.3...6.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.0.3 to 6.1.0. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.0.3...v6.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@hypothesis/frontend-shared](https://github.com/hypothesis/client) from 1.4.0 to 1.7.0. - [Release notes](https://github.com/hypothesis/client/releases) - [Changelog](https://github.com/hypothesis/client/blob/v1.7.0/CHANGELOG.md) - [Commits](https://github.com/hypothesis/client/compare/v1.4.0...v1.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [chai](https://github.com/chaijs/chai) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/master/History.md) - [Commits](https://github.com/chaijs/chai/compare/4.2.0...4.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.2.4 to 8.2.5. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.4...8.2.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.11 to 7.12.13. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-preset-env) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.12.10 to 7.12.13. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-preset-react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.834.0 to 2.839.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.834.0...v2.839.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.0.15 to 18.1.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.0.15...v18.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Post Slack messages about client deployment events to #eng-ci. Messages with a non-success status are also posted to #eng-frontend for visibility. This change is intended to reduce the amount of noise in the Fixes https://github.com/hypothesis/playbook/issues/517
-
- 05 Feb, 2021 8 commits
-
-
Kyle Keating authored
Add /components folder in frontend-shared
-
Eduardo Sanz García authored
Follow instructions from: https://github.com/WICG/focus-visible#shadow-dom Closes #2959 #2689
-
Eduardo Sanz García authored
There are two other .babelrc in the project. I think it gives more consistency and allows for comments.
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
Follow instructions from: https://github.com/WICG/focus-visible#shadow-dom
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
- 03 Feb, 2021 6 commits
-
-
Robert Knight authored
All npm packages should have a license, and yarn complains if there isn't one. The license chosen here is the same as in the client's package.json.
-
Robert Knight authored
Generate TypeScript definition files as part of the frontend-shared package so that TS can typecheck code that uses the package in other projects. Within the client repository we don't need to generate these files because TypeScript will read the JSDoc comments. When the package is consumed from other projects however, it seems that it does not read the JSDoc comments. Note that when these `.d.ts` files exist, they are used in preference to JSDoc comments by other code in the client repository. Therefore they need to be kept up to date when the files are recompiled in watch mode. In the process of adding this I discovered an issue that the method of running CLI commands in gulp tasks in `scripts/gulp/frontend-shared.js` did not fail if the exit status was non-zero. I created a `run` utility that handles this correctly along with providing the desired defaults.
-
Robert Knight authored
-
Robert Knight authored
Change the glob to allow for `test/` dirs inside subdirectories of `frontend-shared/src`.
-
Robert Knight authored
This directory contains the compiled version of code from `frontend-shared/src`. Only the source should be instrumented.
-
Robert Knight authored
`useElementShouldClose` is a useful generic hook for implementing non-modal dialogs. We also use it in the LMS frontend, so it makes sense to share the implementation. This function depends on `normalizeKeyName`, so I moved that as well. `useElementShouldClose` also depended on a `listen` helper. This helper is not currently used by any other code so I moved it into `use-element-should-close.js` as a non-exported helper function and simplified it. In the process I found it was necessary to change the gulp task that builds the frontend-shared/lib/ directory to handle subdirectories under frontend-shared/src/.
-
- 02 Feb, 2021 5 commits
-
-
Robert Knight authored
The previous description was largely about how `useElementShouldClose` was implemented rather than about how it was intended to be used. Rewrite it to explain the what/when rather than how and use fewer words.
-
Robert Knight authored
`useElementShouldClose` allowed passing a ref to a Preact component rather than a ref to a DOM element. Support for this relied on Preact component's having a `base` property, which is going away in future [1] All of the actual usage of `useElementShouldClose` in the app passed an Element ref, so I've simply removed the functionality and associated tests. [1] https://github.com/preactjs/preact/pull/2971
-
Lyza Danger Gardner authored
Refactor the way headless threads are handled regarding visibility and reply toggling. Add an `AnnotationMissing` component; harmonize props between `Annotation` and `AnnotationMissing`. Add a new `AnnotationReplyToggle` component.
-
Lyza Danger Gardner authored
Change `forcedVisibleAnnotations` => `forcedVisibleThreads` and use thread ids instead of annotation $tags. This allows the forcing-visible of threads that lack an annotation and is more appropriate overall: threads are forced-visible, not annotations.
-
Lyza Danger Gardner authored
-
- 01 Feb, 2021 7 commits
-
-
Kyle Keating authored
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.30.0 to 6.0.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.30.0...6.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.3 to 10.2.4. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/10.2.3...10.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.0.1 to 6.0.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.0.1...v6.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.5.11 to 10.5.12. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.5.11...10.5.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.19.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.18.0...v7.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.831.0 to 2.834.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.831.0...v2.834.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-