- 31 Mar, 2017 9 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix Mobile Safari Scrolling
-
Sean Roberts authored
* master: Add tests for sidebar closing when user clicks or taps in document Fixing tapping anchored annotations not opening sidebar Fixing sidebar not closing on outside content click issue eslint: Ignore docs/_build Update ESLint to v3.18.0
-
Robert Knight authored
Since the `<thread-list>` is now contained within a scrollable element which is not `document.body`, it needs to scroll that element rather than the window in order to scroll the element into view. * Remove the hard-coded selector used to find the scroll root and instead search for the closest ancestor element to the `<thread-list>` whose computed style has `overflowY` set to `scroll`. * Set the scroll root Element's `scrollTop` to scroll the thread list instead of calling `window.scroll` * Compute the maximum scroll offset based on the `scrollTop` and `scrollHeight` properties of the scroll root element instead of using `document.body.scrollHeight`. * Update tests for `<thread-list>` to check for the scrollable ancestor being scrolled instead of the window.
-
Robert Knight authored
Fixing sidebar not closing on outside content click issue
-
Robert Knight authored
-
Robert Knight authored
Fixing tapping anchored annotations not opening sidebar
-
- 30 Mar, 2017 7 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
-
Sean Roberts authored
-
Robert Knight authored
eslint: Ignore docs/_build
-
Sean Hammond authored
-
Sean Hammond authored
Update ESLint to v3.18.0
-
Robert Knight authored
- Update ESLint from v3.2.0 to v3.18.0 - Add a little extra configuration for the "indent" rule which best matches our existing practice in the codebase - Fix a few places that were inconsistent about indentation
-
- 29 Mar, 2017 16 commits
-
-
Robert Knight authored
Convert `<top-bar>` to a component
-
Robert Knight authored
Add tests that callbacks and properties are passed down correctly to child components.
-
Robert Knight authored
`frame` is never assigned anywhere and `ng-cloak` is unnecessary since the HTML for the `<top-bar>` component is not present in the page when it loads but is added by Angular after the app has booted.
-
Robert Knight authored
Fix incorrect additions of 'vm.' prefix that were added when converting `<top-bar>` to a component and a missing 'vm.' prefix in the call to log out.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Convert `<hypothesis-app>` to a component
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Rename the modules and templates for the `<hypothesis-app>` component to match the component name, following our conventions.
-
Robert Knight authored
-
Sean Roberts authored
Fix scrolling to new annotations
-
Sheetal Umesh Kumar authored
Convert AnnotationViewerController to a component
-
Robert Knight authored
Output logs from s3-npm-publish Docker container
-
Robert Knight authored
Since #306 which set the height of the `<hypothesis-app>` container element to 100%, the height of `document.body` is now equal to the window's `innerHeight`. As a result, `document.body.clientHeight` now returns the same value as `window.innerHeight` and `scrollOffset()` returns 0. Fix this by using `scrollHeight` instead of `clientHeight`, which takes into account the height of all of the body's descendant elements, including the `<thread-list>`. This calculation would still return the wrong result if the `<thread-list>` were ever placed in a separate scrolling container within the sidebar app window, but that is an acceptible limitation for now.
-
- 28 Mar, 2017 8 commits
-
-
Robert Knight authored
When this test was converted from CoffeeScript to JS, the implicit return of the Promise was not converted to an explicit return. Hence the test would sporadically fail depending on when the Promise callback got executed.
-
Robert Knight authored
To help debug publishing failures, output logs from the container. See https://hypothes-is.slack.com/archives/C076LQFA4/p1490705667081734
-
Sheetal Umesh Kumar authored
Convert `<markdown>` to a component
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Convert AnnotationViewerController to an `<annotation-viewer-content>` component following the same refactoring that was applied to the sidebar and stream.
-
Sean Hammond authored
Convert StreamController to a component
-