Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 02 Sep, 2020 5 commits
  3. 01 Sep, 2020 11 commits
  5. 28 Aug, 2020 1 commit
    • Robert Knight's avatar
      Remove sidebar toggle button swipe gesture handling · 3c849a81
      Robert Knight authored 
      Remove logic for handling swipe gestures on the sidebar's toggle button.
Trying to perform a swipe on a target as small as the toggle button is
difficult and it doesn't offer advantages over just tapping the button
to open and close. Behavior that _might_ be useful is being able to
two-finger swipe on the whole sidebar to open or close it, but this conflicts
with the browser's own swipe gesture handling. Just remove it entirely
for now.

 - Remove swipe gesture handling

 - Remove unnecessary use of jQuery

 - Ensure that the `_setupGestures` code path is exercised by tests
      3c849a81
  7. 27 Aug, 2020 5 commits
    • Robert Knight's avatar
      Convert tests for src/annotator/sidebar.js to JS · 43b7fef8
      Robert Knight authored 
      This is a direct conversion with decaffeinate [1] followed by a manual
line-by-line review to remove unnecessary `return` statements, fix lint
errors and ensure consistency with our conventions.

[1] https://github.com/decaffeinate/decaffeinate
      43b7fef8
    • Robert Knight's avatar
      Add a couple of comments in response to PR feedback · 98d001bd
      Robert Knight authored
      98d001bd
    • Robert Knight's avatar
      Convert src/annotator/sidebar.coffee to JS · 49c5b09b
      Robert Knight authored 
      Convert this module, but not its tests, to JS. This is a pretty
straightforward conversion with a few minor improvements:

 - The initialization of `options` was rewritten in a way that is
   consistent with `PdfSidebar` and avoids a non-idiomatic way of
   passing initialization parameters from derived to base class

 - Some comments that were hard to parse were rewritten or removed if
   they stated something obvious

 - Private methods and fields related to gesture state were prefixed
   with an underscore. Some of the sidebar tests did and still do access
   these, which is not ideal.
      49c5b09b
    • Kyle Keating's avatar
      Add to range-js module · d5066164
      Kyle Keating authored 
      range-js.js will eventually replace range.coffee and then rename to range.js once all the methods are converted.

Include 2 initial functions in range-js
- nodeFromXPath
- xpathFromNode
      d5066164
    • Kyle Keating's avatar
      Copy xpath.coffee & utils.coffee modules to js · 6afb5cca
      Kyle Keating authored 
      Copy several util methods required to convert xpath.coffee, util.coffee and eventually range.coffee into javascirpt. This first step is to just convert the modules straight over and add basic unit tests for them which previously were missing.

A few changes have been made:

- findChild is exposed in part so it can be moved to this module and also be unit tested easily.
- simpleXPathJQuery- will eventually go away, but as a first pass, its being ported
- jquery is kept in this context, but eventually all methods that expect a jquery object will be converted over to pure js.
- typechecking is not complete
      6afb5cca
  9. 26 Aug, 2020 2 commits
  11. 25 Aug, 2020 16 commits