- 02 Jun, 2016 1 commit
-
-
Robert Knight authored
This is a step towards getting us to a place where all important state in the front-end app is managed in the same way - kept in the Redux store and modified only via actions. The sort state was duplicated as a property on the $scope and also stored in the Redux store. Instead just expose functions on the scope which retrieve this state directly from the store and dispatch an action to the store when the user selects a different sort mode. In addition, the terminology for sorting has been normalised across the application (sortBy/sortOptions -> sortKey/sortKeysAvailable), and the ability to sort the stream has been removed, as it was nonsensical and broken.
-
- 27 May, 2016 1 commit
-
-
Christof Dorner authored
devserver: Extend ALLOWED_ORIGINS instead of overriding it
-
- 26 May, 2016 8 commits
-
-
Robert Knight authored
Add padding, fix hover state colours, tweak shadow
-
Conor Delahunty authored
Making this change to increase the visibility of the adder.
-
Nick Stenning authored
Legacy API cleanup
-
Nick Stenning authored
Restructure the documentation
-
Sheetal Umesh Kumar authored
If a selected annotation is unavailable to a user, prompt user to sign in if they are not signed in. If a selected annotation is unavailable to a user and they are already signed in, display a message. See: https://trello.com/c/scNGUMBk/330-improve-copy-to-clarify-direct-linking-functionality
-
Nick Stenning authored
Use human friendly pylint names
-
Nick Stenning authored
Add enter/exit animation when adder is shown
-
Nick Stenning authored
Remove legacy ES code
-
- 25 May, 2016 15 commits
-
-
Robert Knight authored
Usage of this was removed by ba02aee28
-
Robert Knight authored
The previous logic contained several errors and omissions which could result in the card not appearing at the top of the viewport after scrolling. 1. If the set of visible threads changed multiple times before the timeout that triggered re-measuring of visible thread heights changed, then a measured height could be replaced with 0. Add checks to catch this. 2. Account for the target scroll offset changing as a result of the document height increasing after the actual heights of cards become known and consequently the maximum possible scroll offset changes. 3. Correct calculation of the position that we need to scroll the window to in order to have a card positioned at the top of the window. For the first card in the list, the position should be 0 (as returned by visibleThreads.yOffsetOf(...)), and for the Nth card it should be the total height of the N-1 previous cards.
-
Robert Knight authored
The previous delay made the adder feel laggy. A shorter delay gives a snappier feel.
-
Robert Knight authored
Add an entry animation for the adder which makes it 'pop up' or 'pop down', depending on which direction the arrow is pointing. Additionally, animate the color transitions when hovering over the toolbar buttons to soften the changes.
-
Robert Knight authored
This was missed in 6c0e21a5df.
-
Robert Knight authored
Fix several missing 'var' declarations in streamer.js
-
Nick Stenning authored
New threading 4/N - Virtualize the thread list
-
Sean Hammond authored
-
Robert Knight authored
Re-implement the behavior to scroll newly created annotations into view in the sidebar so that the user can start editing them immediately. A complication with doing this given that the annotation list is virtualized is that if we want to scroll to the Nth visible annotation, we may not know the actual heights of the N-1 annotations above it. As a result of scrolling the list, some of the heights of those N-1 annotations may be updated from an estimate to an actual measured height, changing the Y offset that we want to scroll to in order to make the Nth annotation visible. There are a few strategies that we could use for dealing with this: 1. Forcibly render all N-1 annotations and measure their height. This is prohibitively expensive for long annotation lists. 2. Use a cheaper method to calculate the exact height of an annotation. Unfortunately we don't have a way to do this at the moment. 3. Use an iterative approach: a. Estimate the target position based on current known/guessed heights. b. Scroll to the estimated position, which will trigger re-rendering and possibly alter the known thread heights. c. Re-estimate the target position and if it changed, go to step b. This commit implements the third method.
-
Robert Knight authored
These elements are used purely to reserve space for offscreen threads which are not actually present in the DOM, so they should not occupy any space beyond that assigned to their 'height' inline style properties.
-
Robert Knight authored
Annotation cards have a small (~8px) margin at the bottom which needs to be taken into account when computing the height of each thread in order to accurately size the spacer element which reserves space for off-screen threads.
-
Robert Knight authored
Expand the class description to better explain how virtualization improves UI performance.
-
Robert Knight authored
Prior to this unsaved changes were lost when an annotation being edited was scrolled off-screen and the annotation component was destroyed. There was already a mechanism in place for persisting unsaved changes to a temporary store when switching accounts and when switching groups but this was only triggered when the signed in user changed or the focused group changed. This commit unifies the handling of all three cases by listening for the '$destroy' event which is fired whenever an <annotation> is about to be destroyed.
-
Robert Knight authored
Use transform3d() to force the top bar onto a new compositor layer so that it does not judder around when scrolling the window. The better fix here will be to make the body scroll rather than the whole window.
-
Robert Knight authored
Make the sidebar handle "large" (ie. 50+) numbers of annotation threads much better by virtualizing the thread list. Virtualizing means that we only instantiate <annotation-thread> components for threads which are either in or 'near' (above/below) the viewport. For the remaining offscreen threads space is reserved by a couple of <li> elements above and below the visible threads.
-
- 23 May, 2016 2 commits
-
-
Robert Knight authored
Following the introduction of the <annotation-thread> component this is now unused. This also removes the JWZ threading implementation since the functionality this provided is now implemented by `build-thread.js`
-
Nick Stenning authored
New threading 3/N - Render annotation threads using new threading infrastructure
-
- 13 May, 2016 10 commits
-
-
Robert Knight authored
Make the behavior of the new threading implementation consistent with that of the previous threading implementation by displaying the total number of visible annotations (+ replies) as the search result count.
-
Christof Dorner authored
Fix "Set changed size ..." error in websocket server
-
Nick Stenning authored
Postgres to ElasticSearch reindexer
-
Robert Knight authored
As noted in https://github.com/hypothesis/h/pull/3284#issuecomment-219031557 threads which have been explicitly collapsed need to have their expansion state reset when the filter query changes. This commit resolves this by moving the search query and sort UI state into the annotationUI Redux store and handles the state update in a SET_FILTER_QUERY action. This means that the rootThread module no longer maintains any primary state of its own, just state derived from the current annotationUI state.
-
Robert Knight authored
Given a thread like this: A- |- B |- C |- D |- E Where only 'B' matches the search filter, the rendered output should be: View 4 more in conversation |- B View two more in conversation
-
Robert Knight authored
Only annotations, not replies can be selected, so only filter top-level annotations against the selection map. This resulted in an issue where 'View N more in conversation' being shown where 'N' was the number of replies when selecting an annotation with replies in the page. See https://github.com/hypothesis/h/pull/3285#issuecomment-218734287
-
Robert Knight authored
This replaces the rendering of conversation threads using the new threading implementation. * Add <annotation-thread> component to render Thread objects generated by rootThread. * Expose the Thread generated by the `rootThread` service on the scope so that <annotation-thread> can render it. * Remove logic and tests in <annotation> for updating reply counts and thread states as these are no longer needed.
-
Robert Knight authored
This adds a service that listens for changes in the UI state and the set of loaded annotations and generates a thread structure in response, which can then be visualized by a view. This commit also adds a first integration test which wires together the non-visual parts of the new threading implementation. * Add 'annotations' to the UI state in annotationUI and update this when annotations are loaded or unloaded. * Add rootThread which listens for changes in the UI state and generates a new conversation thread structure in response. * Add an integration test which tests the wiring of the non-visual parts of the new threading implementation.
-
Robert Knight authored
This adds a service that listens for changes in the UI state and the set of loaded annotations and generates a thread structure in response, which can then be visualized by a view. This commit also adds a first integration test which wires together the non-visual parts of the new threading implementation. * Add 'annotations' to the UI state in annotationUI and update this when annotations are loaded or unloaded. * Add rootThread which listens for changes in the UI state and generates a new conversation thread structure in response. * Add an integration test which tests the wiring of the non-visual parts of the new threading implementation.
-
Christof Dorner authored
Move hypothesis-celery command to h.cli
-
- 12 May, 2016 3 commits
-
-
Robert Knight authored
Prune old and crufty migrations
-
Christof Dorner authored
Add a `hypothesis migrate` command
-
Nick Stenning authored
New threading 1/N - Begin to centralize UI state in annotationUI
-