1. 21 Oct, 2015 5 commits
    • Sean Hammond's avatar
      Rename "public" -> "shared" · 7b6c8560
      Sean Hammond authored
      Rename permissions.public() -> permissions.shared() and
      permissions.isPublic() -> permissions.isShared().
      
      This is more consistent with language used elsewhere in the code, now
      that we have groups.
      7b6c8560
    • Sean Hammond's avatar
      Set group and visibility of reply to that of parent · 6fe1e357
      Sean Hammond authored
      Set the group and visibility of replies to that of their parents, when
      replies are first created.
      
      Also prevent the visibility setting of a reply from overwriting the
      cached-in-local-storage visibility level. This prevents the following
      problem:
      
      - I'm annotating publicly (my cached-in-local-storage visibility
        setting is public)
      - I reply to a private annotation
      - The visibility of my reply is set to that of its parent, private
      - This visibility is then cached in local storage
      - I make a new top-level annotation, and now it's defaulting to private
        instead of public, even though the user never did anything to change
        the visibility from public to private, it was done automatically
        because they replied to a private annotation.
      
      Obviously changing the mode from private to public when replying to a
      public annotation was also possible.
      
      This means that if the user _does_ change the visibility of a reply, we
      _don't_ cache that either:
      
      - I'm annotating publicly (my cached-in-local-storage visibility
        setting is public)
      - I reply to a public annotation
      - The visibility of my reply is set to that of its parent, public
      - This visibility is not cached in local storage because it's a reply
        (and the value cached in the local storage is already the same anyway)
      - I then deliberately change the visibility of my reply from public to
        private
      - Again this visibility is not cached in local storage because it's a reply
      - The next time I make a new top-level annotation, it will still be
        defaulting to public, will not have changed to private mode
      6fe1e357
    • Nick Stenning's avatar
      Merge pull request #2635 from hypothesis/remove-get-by-userid · 17954cf0
      Nick Stenning authored
      Remove get_by_userid()
      17954cf0
    • Nick Stenning's avatar
      Merge pull request #2639 from robertknight/extension_build_type_indicator · 39b53e3a
      Nick Stenning authored
      Extension build type indicator
      39b53e3a
    • Sean Hammond's avatar
      Merge pull request #2647 from hypothesis/fix-changing-size-socketlist · fbdca150
      Sean Hammond authored
      Iterate over a copy of the open websockets list
      fbdca150
  2. 20 Oct, 2015 4 commits
  3. 19 Oct, 2015 8 commits
  4. 16 Oct, 2015 17 commits
  5. 15 Oct, 2015 6 commits
    • Robert Knight's avatar
      Increase top bar height to 40px · 37127a8c
      Robert Knight authored
      Increase top bar height to 40px to match the designs.
      A visual side effect is that the dropdown menus now
      overlap the top bar and clearly appear on top of it
      rather than just below.
      37127a8c
    • Robert Knight's avatar
      Adjust dropdown menu arrow location for groups list · be78fc2b
      Robert Knight authored
      Position the arrow at the top of the groups list
      dropdown menu so that it appears beneath the
      dropdown indicator in the top-bar.
      
      This is done by hiding the dropdown menu's "built in"
      arrow created via CSS :before and :after pseudo-elements
      and introducing a separate element which uses the same
      technique with borders to create the dropdown arrow.
      
      The use of a separate element for the arrow allows it
      to be aligned with the right edge of the dropdown menu's
      parent element (in this case, the group name in the top bar)
      rather than the dropdown menu's content.
      be78fc2b
    • Robert Knight's avatar
      Simplify styling of top-bar · 7a7c2510
      Robert Knight authored
       * Set the inner container in the top bar to the full height
         of the top bar.
      
         This corrects the vertical alignment of the toolbar icons.
      
       * Remove the extraneous 'content' class from the top bar
      
       * Remove unused selectors for button styling
      
      T-90
      7a7c2510
    • Robert Knight's avatar
      Collapse the search input when the search query is empty · 648dd657
      Robert Knight authored
      When the new top-bar design is enabled,
      collapse the search input unless the field is hovered,
      focused or there is an active search query.
      
      In the legacy top-bar design, the search field remains
      expanded all the time
      
      T-90
      648dd657
    • Robert Knight's avatar
      Merge pull request #2619 from hypothesis/explicit-settings-for-websocket · 4490b70c
      Robert Knight authored
      Explicit settings for websocket
      4490b70c
    • Nick Stenning's avatar
      Use websocket URL provided in settings · 8334e2f7
      Nick Stenning authored
      Rather than constructing a URL from hard-coded defaults in the streamer
      service, we pass the websocket URL from the backend in the settings
      object and use this when opening the websocket.
      8334e2f7