1. 20 Mar, 2018 4 commits
    • Robert Knight's avatar
      Restructure Redux store directory tree · 8bb28c60
      Robert Knight authored
      Following the plan outlined in #687, restructure the Redux store as
      follows:
      
       - Move the entry point from `services/annotation-ui.js` to `store/index.js`
       - Move the modules which define bundles of reducers, action creators
         and selectors to `store/modules/{module-name}.js`
       - Move related utility code to `store/{module-name}.js`
      8bb28c60
    • Robert Knight's avatar
      Merge pull request #692 from hypothesis/move-services · d3a567fa
      Robert Knight authored
      Move sidebar services to src/sidebar/services/
      d3a567fa
    • Robert Knight's avatar
      Move services to `services/` directory · 3e7626f8
      Robert Knight authored
      Following the plan outlined in #687, move services into a `services/`
      directory.
      
      The definition of "services" in that plan (a possibly stateful module
      that handles interaction with an external party) is slightly more narrow
      than what constitutes an Angular service (a stateful singleton that has
      dependencies on injectable services/values).
      
      However as a first approximation most Angular services are services as
      defined in #687, so I've simply moved them all to the `services/`
      directory.
      3e7626f8
    • Robert Knight's avatar
      Merge pull request #691 from hypothesis/rename-store-service · d97b07ac
      Robert Knight authored
      Rename src/sidebar/{store => services/api}
      d97b07ac
  2. 19 Mar, 2018 1 commit
    • Robert Knight's avatar
      Rename src/sidebar/{store => services/api} · db95bfeb
      Robert Knight authored
      Give the service which provides a client for the Hypothesis API a more
      obvious name and place it in a `services/` dir in accordance with the
      plan outlined in #687. The previous name of "store" was particularly
      confusing because of the existence of another kind of unrelated store
      (the Redux one) in the application.
      
      The service was previously registered with the `factory` method but has
      the same structure as all the other services which are registered with
      `service`, so I changed that for consistency.
      db95bfeb
  3. 16 Mar, 2018 2 commits
  4. 12 Mar, 2018 2 commits
  5. 08 Mar, 2018 5 commits
  6. 07 Mar, 2018 3 commits
  7. 01 Mar, 2018 1 commit
  8. 26 Feb, 2018 1 commit
  9. 21 Feb, 2018 4 commits
  10. 20 Feb, 2018 3 commits
  11. 19 Feb, 2018 8 commits
  12. 18 Feb, 2018 1 commit
  13. 16 Feb, 2018 5 commits
    • Robert Knight's avatar
      v1.67.0 · 6057a0d7
      Robert Knight authored
      6057a0d7
    • Robert Knight's avatar
      Update Change Log · 33bfc1d8
      Robert Knight authored
      33bfc1d8
    • Sheetal Umesh Kumar's avatar
      Merge pull request #674 from hypothesis/only-wait-for-doc-uri-in-sidebar · 0c29751a
      Sheetal Umesh Kumar authored
      Only wait for document URI before fetching groups in sidebar
      0c29751a
    • Robert Knight's avatar
      Only wait for document URI before fetching groups in sidebar · 233450db
      Robert Knight authored
      Fixes a regression after 36c46608 where the stream and single
      annotation page views failed to load.
      
      36c46608 made the groups service wait for the host page's document URI
      to be determined before making a call to the `/api/groups` endpoint
      passing that URI as a parameter. In the stream (`/stream`) and single
      annotation page routes, there is no host page and so
      the promise returned by `getDocumentUriForGroupSearch` never resolved.
      Avoid waiting for this URI in that case and avoid passing the
      `document_uri` parameter to the `/api/groups` endpoint.
      
      This commit introduces a new `isSidebar` test rather than using
      `annotationUI.isSidebar` because that piece of app state is not yet
      initialized at the point when `groups.load()` is called in the route's
      `resolve` function in src/sidebar/index.js.
      233450db
    • Robert Knight's avatar
      v1.66.0 · 607a2023
      Robert Knight authored
      607a2023