- 06 Sep, 2016 1 commit
-
-
Robert Knight authored
Do not hide annotation thread when annotations are waiting to anchor.
-
- 05 Sep, 2016 1 commit
-
-
Sheetal Umesh Kumar authored
When an annotation is created or updated the sidebar briefly transitions into the `waitingToAnchor` state and hides the entire thread list, losing the user's scroll position as a result. Instead of hiding the entire thread, filter out the annotations which are waiting to anchor. https://trello.com/c/hQRpsUPj/444-avoid-hiding-thread-list-while-new-annotations-received-over-ws-are-being-anchored
-
- 02 Sep, 2016 5 commits
-
-
Robert Knight authored
Document the default values of client config keys
-
Nick Stenning authored
-
Robert Knight authored
Document the `showHighlights` config option
-
Nick Stenning authored
-
Robert Knight authored
On group change, reset tab selection to annotations if the selected t…
-
- 30 Aug, 2016 1 commit
-
-
Sheetal Umesh Kumar authored
-
- 23 Aug, 2016 2 commits
-
-
Robert Knight authored
This is not used by the client. The client does use the [Angular Bootstrap](http://angular-ui.github.io/bootstrap/) 3rd-party module for dropdown menus but that does not use the Bootstrap build's JS or CSS.
-
Nick Stenning authored
Remove unused CSS
-
- 19 Aug, 2016 4 commits
-
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
This file is used only by the H service
-
Robert Knight authored
Remove unused CSS rules. These were found by using used-css-classes [1] and find-unused-css-classes [2]: used-css-classes h/templates/client/*.html > used-classes.txt find-unused-css-classes used-classes.txt build/styles/app.css > unused-css-classes And then manually checking classes in `unused-css-classes` to verify that the classes were not referenced in first or third-party code, since the tools only extract used class names from templates. [1] https://github.com/robertknight/used-css-classes [2] https://github.com/robertknight/find-unused-css-classes
-
Robert Knight authored
This caused a parsing exception in BeautifulSoup when gathering the set of used CSS classes with https://github.com/robertknight/used-css-classes
-
- 12 Aug, 2016 2 commits
-
-
Nick Stenning authored
- #!/bin/sh is in POSIX, no need for env - `set -eu` to explode if something fails or a var isn't defined - a simpler way of ensuring we're in the right place to run the releaser script. - "git push --follow-tags" will push pending commits and annotated tags attached to them in a single command
-
Robert Knight authored
Avoid an issue where trying to create a GH release immediately after pushing the tag often fails.
-
- 11 Aug, 2016 1 commit
-
-
Robert Knight authored
In browsers that support Shadow DOM (currently only Chrome, plus Firefox behind a feature flag), use it to isolate the adder from the host page's CSS. This fixes various problems where very generic CSS on the page could affect the adder's styling.
-
- 09 Aug, 2016 4 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
- Only mark annotations as orphans after a timeout in the sidebar, not in the stream where anchoring does not happen. - Do not filter annotations by type on the stream, where annotation tabs are not displayed.
-
Robert Knight authored
When the orphans feature flag is not set, do not indicate orphans in annotation cards by striking through their quotes. The feature flag is hoisted outside of the `isOrphan` call because I recall that `flagEnabled` was actually quite an expensive call in the past so we want to avoid invoking it during every digest cycle.
-
- 08 Aug, 2016 5 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
If an annotation is loaded and then quickly removed before the anchoring timeout expires, the call to `findByID()` will return null, causing an error when trying to check the `$orphan` flag in `isWaitingToAnchor`. Fix this by ignoring annotations which no longer exist when the timeout expires.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
- 05 Aug, 2016 6 commits
-
-
Robert Knight authored
If anchoring an annotation fails to complete within 500ms then assume that an error occurred during anchoring and that the annotation is therefore an orphan. If it later turns out that anchoring just took a long time then the annotation will simply move from the Orphans tab to the Annotations tab once anchoring completes. A timeout within the sidebar app is used rather than relying on the page code to send back a message if an error occurs during anchoring because the code that runs in the page context could fail in arbitrary ways due to interactions with JavaScript on the page.
-
Robert Knight authored
-
Robert Knight authored
Remove the 'selection_tabs' feature flag
-
Nick Stenning authored
This is now enabled for all users.
-
Robert Knight authored
Separate anchored and unanchored annotations into tabs.
-
Robert Knight authored
Avoid problems due to loss of type information when passing config options from the page to the sidebar app by serializing the app config object as a JSON string and then de-serializing it in app.js
-
- 04 Aug, 2016 7 commits
-
-
Robert Knight authored
When there are no orphans, the Orphans tab is not shown, so we need to switch back to the Annotations tab in that case.
-
Robert Knight authored
Refactor some repetition in the functions that produced the counts for the Annotations, Page Notes and Orphans tabs and extract it into a separate module where it is easier to test. Moving this into a single function also makes it easier to memoize later, so we can avoid recalculating it when the list of annotations has not changed between two app states.
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Default to the annotations tab when user switches between groups, clears a selection or reloads a page. The ANNOTATIONS_SYNCED event is emitted when annotations for a document have finished anchoring. Because annotations are not marked as orphans until they fail to anchor, select the annotations tab after they have finished anchoring. Test cases: ------------- 1. On page load localhost:3000 annotations tab is selected. clicking on new note switches to the notes tab with a new draft created. switching between tabs maintains tab selection, if notes or annotations. when tab selected is orphans, changing groups defaults to the annotations tab. 2. On page load localhost:3000/#annotations:<id> clicking on new page note should select the notes tab. When an annotation/note is selected, the tab selection carries between group changes. all tests listed in #1 above should apply. 3. On page load localhost:3000/#annotations:<orphan_id> clicking on “show all annotations and notes” selects the annotations tab and displays all annotations. all tests listed in #1 and #2 above should apply. switching between groups selects the annotations tab by default https://trello.com/c/1NVK2jwv/400-add-a-tab-for-unanchored-annotations https://trello.com/c/OLdLTlLT/342-separate-annotations-and-notes Hide orphans tab behind orphans_tab flag. Fix bug where notes tab isn't selected when user attempts to create a new page note.
-
Robert Knight authored
Update an annotation's anchoring status and local tag via a Redux action rather than just direct assignment to the annotation's properties. This ensures that store subscribers and a digest cycle happen after the anchoring status changes. This in turn ensures that the UI state is kept in sync. This also brings us another step closer to being able to make annotation objects immutable within the sidebar app.
-
Robert Knight authored
Add a service which maps named, parameterized routes to corresponding URLs on the Hypothesis service. This makes it easier to identify which URLs the client links to on the service and update all uses of a particular URL.
-
Sheetal Umesh Kumar authored
-
- 03 Aug, 2016 1 commit
-
-
Robert Knight authored
Replace "firstRun" config option with "openSidebar" and "openLoginForm"
-